kubowania / minesweeper Goto Github PK
View Code? Open in Web Editor NEWA simplified game of minesweeper using vanilla JavaScript
A simplified game of minesweeper using vanilla JavaScript
The code-block containing the line 152 is as follows:
if (currentId < 89) {
const newId = squares[parseInt(currentId) +width].id
//const newId = parseInt(currentId) +width ....refactor
const newSquare = document.getElementById(newId)
click(newSquare)
}
As it stands, if we were to click square #89, then the very last square in the grid, #99, would not be run through the click function.
We should instead check for currentId < 90
to avoid this off by one error:
if (currentId < 90) {
const newId = squares[parseInt(currentId) +width].id
//const newId = parseInt(currentId) +width ....refactor
const newSquare = document.getElementById(newId)
click(newSquare)
}
After fixing this, we also have to change line 54:
if (i < 89 && squares[i +width].classList.contains('bomb')) total ++
We likewise should add 1 to the amount we are checking:
if (i < 90 && squares[i +width].classList.contains('bomb')) total ++
Am I the only one having performance issue?
Once the recursion is triggered, everything slows down... Like a lot.
Is this code scalable to bigger grid?
Line 105 in bb3641f
const newSquare = document.getElementById(newId)
click(newSquare)
it can come ones at the end of the function instead in every if block
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.