kubowania / minesweeper Goto Github PK

The code-block containing the line 152 is as follows:

if (currentId < 89) {
        const newId = squares[parseInt(currentId) +width].id
        //const newId = parseInt(currentId) +width   ....refactor
        const newSquare = document.getElementById(newId)
        click(newSquare)
      }

As it stands, if we were to click square #89, then the very last square in the grid, #99, would not be run through the click function.

We should instead check for currentId < 90 to avoid this off by one error:

if (currentId < 90) {
        const newId = squares[parseInt(currentId) +width].id
        //const newId = parseInt(currentId) +width   ....refactor
        const newSquare = document.getElementById(newId)
        click(newSquare)
      }

After fixing this, we also have to change line 54:

if (i < 89 && squares[i +width].classList.contains('bomb')) total ++

We likewise should add 1 to the amount we are checking:

if (i < 90 && squares[i +width].classList.contains('bomb')) total ++

Am I the only one having performance issue?
Once the recursion is triggered, everything slows down... Like a lot.
Is this code scalable to bigger grid?

   const newSquare = document.getElementById(newId)
        click(newSquare)

it can come ones at the end of the function instead in every if block