Comments (11)
jayunit100
commented on July 20, 2024
reproducing
mkdir larscp examples/print-state/main.go lars/cd lars ; go mod init test.com/example- observe that the mod init fails, bc of our attempt to import
k8s.io/[email protected]
➜ lars go get sigs.k8s.io/kpng/client
go: downloading sigs.k8s.io/kpng v0.0.0-20210813170222-0c0a3c81012c
go get: sigs.k8s.io/kpng@none updating to
sigs.k8s.io/[email protected] requires
k8s.io/[email protected] requires
k8s.io/[email protected]: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0
from kpng.
jayunit100
commented on July 20, 2024
kubernetes/kubernetes#79384 <-- we'll need to fix this
from kpng.
uablrek
commented on July 20, 2024
We must not require backends consume k8s.io/kubernetes as a module, see kubernetes/kubernetes#79384 (comment)
It might be that kpng itself must do that, but definitely not a backend!
from kpng.
uablrek
commented on July 20, 2024
I think the problem is "k8s.io/klog". It is a K8s internal thing and MUST NOT be required by out-of-tree backends.
from kpng.
uablrek
commented on July 20, 2024
@jayunit100 Please remove make kpng vendorable from the title. This is not about vendoring, it's about go modules. (as much as I love go I hate vendoring)
from kpng.
jayunit100
commented on July 20, 2024
tried to remove klog from the client but, for some reason even though the client doesnt depend on k8s.io, still seeing:
➜ lars go mod tidy
go: found sigs.k8s.io/kpng/client in sigs.k8s.io/kpng v0.0.0-00010101000000-000000000000
go: sigs.k8s.io/[email protected] requires
k8s.io/[email protected] requires
k8s.io/[email protected]: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0
reproduce with
➜ lars cat go.mod
module test.com/example
go 1.17
replace sigs.k8s.io/kpng => ../kpng
from kpng.
uablrek
commented on July 20, 2024
It still doesn't work. Example:
cp -r examples/pipe-exec/ /tmp
cd /tmp/pipe-exec
rm -f go.mod go.sum
go mod init github.com/kubernetes-sigs/kpng/examples/pipe-exec
go mod tidy
go: finding module for package sigs.k8s.io/kpng/client
go: found sigs.k8s.io/kpng/client in sigs.k8s.io/kpng/client v0.0.0-20211015205115-eb27050d1b40
go: downloading sigs.k8s.io/kpng/api v0.0.0-00010101000000-000000000000
github.com/kubernetes-sigs/kpng/examples/pipe-exec/cmd/kpng-callout imports
sigs.k8s.io/kpng/client imports
sigs.k8s.io/kpng/api/localnetv1: sigs.k8s.io/kpng/[email protected]: invalid version: unknown revision 000000000000
/open
from kpng.
uablrek
commented on July 20, 2024
/reopen
from kpng.
k8s-ci-robot
commented on July 20, 2024
@uablrek: You can't reopen an issue/PR unless you authored it or you are a collaborator.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from kpng.
mcluseau
commented on July 20, 2024
@uablrek I've gone through a cleanup step on all this, please try again :)
from kpng.
uablrek
commented on July 20, 2024
Now it works 👍
from kpng.
Related Issues (20)
- broadly investigate the NFT errors on ipv6 HOT 6
- prototype a dpdk impl HOT 3
- investigate adding rpc tracing support HOT 7
- Ginkgo focus is not working on ./hack/test_e2e.sh script HOT 6
- fix command line flag parsing in cmd/kpng/*.go HOT 5
- comprehensive comments/docs on the Endpoints client and the kpng/client/client.go HOT 5
- Create an issue and pull request template for standard HOT 3
- test flake on "[It] should be able to handle large requests: http" HOT 4
- Add a Tilt README HOT 2
- Regenerate skip_test_list HOT 5
- KPNG ipv6 and ipvs have failing coredns pod HOT 6
- healthz server is not setup in core component HOT 4
- Using kind images with SHA digest in e2e HOT 5
- Graceful Termination for IPVS endpoints HOT 4
- error when deploying kpng with nft mode in kind cluster HOT 4
- Context (ctx) is used in a non-idiomatic way HOT 6
- Only one family endpoints for dual-stack service HOT 1
- github actions updates and docs HOT 8
- eBPF ClusterIP support with XDP HOT 7
- Add doc about the multiple named ports HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kpng.