Comments (8)
sbueringer
commented on July 24, 2024
2
This CAPI action might be useful https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml
from kpng.
FZhg
commented on July 24, 2024
1
Hi @aroradaman, I want to work on this! I have enough time. I have read the thread as well. This is my first time to contribute to k8s! 🐳
from kpng.
aroradaman
commented on July 24, 2024
1
Currently, the GitHub actions are only being triggered when PR has approved and lgtm labels.
We would love to have them triggered without any dependency on these two labels.
from kpng.
k8s-ci-robot
commented on July 24, 2024
@jayunit100:
This request has been marked as suitable for new contributors.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
Looks like we've got some tech debt around the lifecycle for our github actions https://kubernetes.slack.com/archives/C02GA1RSCLR/p1692815992205469 ...
- We want them to run for every PR when a PR happens
- We want them to run before merges happen
- We want them to pass for PRs that dont make breaking changes
Can someone verify this for us and update our README with a guide for how our CI is currently working? As a starting point:
- clone this repo,
- look at the .github actions and understand them (ask question sin the sig-network-kpng slack channel if not sure what things are doing, cc @friedrichwilken or @aroradaman or me
- Go to the sig-testing weekly meeting to get an understanding if wanting to understand how / when github actions are triggered on new PRs (from K8s members? what about from non K8s members? How are the actions triggered differently) ?
/good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from kpng.
aroradaman
commented on July 24, 2024
Currently, the GitHub actions are only being triggered when PR has approved and lgtm labels.
We would love to have them triggered without any dependency on these two labels.
from kpng.
FZhg
commented on July 24, 2024
/assign
from kpng.
FZhg
commented on July 24, 2024
Hi @jayunit100, could you give me a reference that how the CI guide should look like? Also, Should I check the Prow documentation for verifying the current behavior of the ok-to-test label?
from kpng.
FZhg
commented on July 24, 2024
Hi, @aroradaman! I have gone through the gh action files and found out that besides docker-action.yml , these files just runs different scripts in the hack directory.
Should a PR trigger the docker-action as well?
from kpng.
Related Issues (20)
- broadly investigate the NFT errors on ipv6 HOT 6
- prototype a dpdk impl HOT 3
- investigate adding rpc tracing support HOT 7
- Ginkgo focus is not working on ./hack/test_e2e.sh script HOT 6
- fix command line flag parsing in cmd/kpng/*.go HOT 5
- comprehensive comments/docs on the Endpoints client and the kpng/client/client.go HOT 5
- Create an issue and pull request template for standard HOT 3
- test flake on "[It] should be able to handle large requests: http" HOT 4
- Add a Tilt README HOT 2
- Regenerate skip_test_list HOT 5
- KPNG ipv6 and ipvs have failing coredns pod HOT 6
- healthz server is not setup in core component HOT 4
- Using kind images with SHA digest in e2e HOT 5
- Graceful Termination for IPVS endpoints HOT 4
- error when deploying kpng with nft mode in kind cluster HOT 4
- Context (ctx) is used in a non-idiomatic way HOT 6
- Only one family endpoints for dual-stack service HOT 1
- eBPF ClusterIP support with XDP HOT 7
- Add doc about the multiple named ports HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kpng.