ktt-development / rexedia Goto Github PK

This is meant to address #24.

Have the following levels for validation:

• 0 > skip validation
• 1 > must have frames within margin of error ~100 (fixed)

  possibly add -vs strength parameter to change the number

• 2 > must have frames equal to or exceed declared
• 3 > must have frames exact

The derived image is always corrupted.

JUnit has its own methods for temporary file creation.

Resolves #19

It seems that eo-yaml no intention on fixing this issue in a timely matter. This dependency will be dropped and replaced with a different yaml library. Modularity is not an issue as apache commons cli is not modular.

Apache Commons Exec and Apache Commons CLI are not actually modular applications as advertised.
This is a dependency issue and will not be resolved.

Videos that have more calculated frames than stated frames will have a false negative on video validation. These videos have extra frames but the videos are still playable. It is unclear if negative frames is what causes video corruption.

Prerequisites

If all checks are not passed then the issue will be closed.

• I have checked that no other similar issue already exists.
• I have checked that this is actually an issue and not a feature.

Operating System: Operating system name and version.
Windows 10

Release Version: Release version or branch commit where the issue occurred.
rdfw@8b11a29

Issue

Explain your issue. Add any screenshots here.
FFMPEG always says permission denied when writing to output file even when running as administrator.
This is an FFMPEG issue and not a code issue.

rexedia may fail if the user has an invalid or incomplete ffmpeg installation.
rexedia is already distributed with a runtime and ffmpeg so it makes sense to use it instead.

Prerequisites

If all checks are not passed then the request will be closed.

• I have checked that no other similar feature request already exists.
• I have checked that this feature does not already exist.
• The feature request makes sense for the project.

Proposal

Describe the feature that should be added.
Extend the regxp/back ref feature to determine the output file.

Reasoning

Explain why this feature should be added.
Allows for even quicker operations and more file stability.

the cover image track is lost using this flag

Remove core dependency and use local classes instead.

Issue is most likely caused by console logger being created AFTER command line args are parsed.

jpackager is causing the console logger to fail. Jar works fine.

Currently the bin is located in the same folder as the exe, however jpackage requires resources to be in the /app directory. This is required for #30.

Move /bin to /app/bin and change directories for these files:

- new FFMPEG("bin/ffmpeg","bin/ffprobe"); 
+ new FFMPEG("app/bin/ffmpeg","app/bin/ffprobe"); 

Since all future Java applications are deployed with their own runtime environment, it is safe to use later versions of JDK without requiring any extra steps from the client.

New features that are safe to implement:

• jpackage [JDK14]
• textblocks [JDK15]
• sealed classes [TBD]
• records [TBD]

Add a build script to generate exe installers

javase/15/jpackage/manage-installation

Certain dependency files can be removed as they are unused.

Additionally the main javascript file can also be minified.

Metadata presets will only parse the first metadata field in the list, not the whole list.

Probable fix: using YamlSequence.values() for the foreach loop.

Fix thread hold issue on #waitFor by checking if last line was a terminate batch requests (y/n) instead of using a future

upgrade to JUnit5

Develop an online JS tool to create preset files.

Count frames is very slow on FFPROBE and should be read from FFMPEG instead (given by default).

Duration may also be rounded so there needs to a method to account for a small margin of error (±0.0001s)

TODO:

• Change copy to use FFMPEG instead so we can read frames.
• Add method to read frames from output.
• Change ffprobe to not count frames.

Current setup requires code to compile regexp each time this function is run. This is inefficient, especially for large batches and should be compiled at instantiation.

JDK-8230863

For this to be fixed the binaries must be compiled with JDK15+

When attempting to remove the cover art track the video track is removed instead.

When GitHub environments is released require manual approvals for deployments.