ktrace / pxmx-ctld Goto Github PK

systemctl restart pvedaemon
systemctl restart pveproxy
systemctl restart pvestatd

echo "Logout from PVE webgui and clean the browser cache and login again."
echo "Ctld should be available as a iSCSI provider without restart any node or cluster service."

Hi.
I tested the driver on proxmox 6.3.x and 6.4.x.
One problem that occurs is the resize.
To reproduce follow the steps:

1. Select the VM.
2. Click Hardware.
3. Select storage disk.
4. Click Resize.
5. Enter the increment in GB and click OK.

An error phrase will appear saying that the lun could not be located.

On FreeBSD the volume has been updated (ie incremented).

Temporary operation:

1. After the error click ok.
2. On FreeNSD SAN (where the ctld is) do /etc/rc.d/ctld reload (so the new size will be updated via iscsi).
3. In Proxmox, dettach the HD and attach again.
   Okay, it will appear with the new size in proxmox. Now just enter in VM and do the internal operation of extending.

At line 350 of CTLD.pm $candidate is always reported as empty variable and the script is failing because you are using "==" instead of "eq" for checking of the variable is set/empty.

I have fixed it for me but cannot commit my changes in your repo. Suggest if you still work on this project to fix it.

The Patch files also needs refreshment, but I don't have the time to create one so I just patched manually.

Setup

Storage1:

target iqn.storage1.lan:storage1 {
     auth-group no-authentication
     portal-group pg0
     lun 0 {
           path /dev/zvol/iscsi/vm-101-disk-0
     }
}

Storage2:

target iqn.storage2.lan:storage2 {
	auth-group no-authentication
	portal-group pg0
}

After moving the storage I somehow expected:

Storage1:

target iqn.storage1.lan:storage1 {
     auth-group no-authentication
     portal-group pg0

}

Storage2:

target iqn.storage2.lan:storage2 {
	auth-group no-authentication
	portal-group pg0
     lun 0 {
           path /dev/zvol/iscsi/vm-101-disk-0
     }
}

What I actually got was:

Storage1:

target iqn.storage1.lan:storage1 {
     auth-group no-authentication
     portal-group pg0
}
iqn.storage2.lan:storage2 {                       ### <<<--- Note missing "Target" at the beginning 
     lun 0 {
           path /dev/zvol/disk_d/vm-101-disk-0
     }
}

Storage2:

target iqn.storage1.lan:storage1 {
     auth-group no-authentication
     portal-group pg0
     lun 0 {
           path /dev/zvol/iscsi/vm-101-disk-0
     }
}


iqn.storage2.lan:storage2 {                       ### <<<--- Note missing "Target" at the beginning  even thou it was correct before

     lun 0 {
          path /dev/zvol/disk_d/vm-101-disk-0
    }
}

Some observations:

1. For some reason the storage1 target configuration is being copied to the storage2 ctl.conf
2. The word "Target is missing"
3. The storage2 configuration has copied the target configuration from storage1 having the word "target" but then it's own config misses the "target" word
4. The storage1 don't delete the LUN section after migration
5. All target configurations have the LUN inside everywhere
6. ZFS volumes, LUN mappings in the runtime config are being correctly handled. However one ctld restart with this messed up configs may cause a disaster.
7. Haven't tested how all good runtime LUN mappings and zvols after migration but messed up ctl.conf files will affect attempt for second migration e.g. what data will be taken from configs and what from LUN mappings and what will it result in
8. Deleting VM with it's disks will fail after a migration happened probably due to messed up ctl.conf files

Generated on Proxmox 6.4.1
pvemanagerlib.js.patch.txt