Giter Club home page Giter Club logo

book_it's Introduction

Review That Book!

  • Ruby Version: 2.3.0

  • Rails Version 5.0.1

  • Configuration

  • Database creation

  • Database initialization

  • How to run the test suite

  • Services (job queues, cache servers, search engines, etc.)

  • Deployment instructions

  • ...

book_it's People

Watchers

Katie Dodd avatar

book_it's Issues

Basic Feedback

commit messages could be a bit more specific (ie. updated user profile with working user image)
Would be nice to have a comments in code explaining what it does. I forget this as well, but something to keep in mind.
reading_list_controller has commented out code without any comments as to why it is commented out.
password_reset_controller has a LOT of very good comments, i assume they came with the gem? Might want to clean them up a bit to be more consistent with the rest of your code. Anyone looking at your code will definitely think that was gem generated comments.
Indentation and syntax is really consistent and well spaced. Good job!
A lot of migration files. I wonder if scraping your DB and rewriting your models might help clean up the list a bit. Seeing a lot of Add Columns, potential employers looking through the code could possibly view that as sloppy.
read me does not have any information
I see some styling in application.scss that could be in books.scss

Note: Great job with the time you had. Really like the idea and what you have so far.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.