ksonnet / parts Goto Github PK

See todo:

https://github.com/ksonnet/parts/blob/master/incubator/efk/efk.libsonnet

At a minimum, we want CI to invoke the Jsonnet compiler with the correct -J flags to make sure PRs don't break the examples, and perhaps also to make sure examples emit the same code as a golden version.

To reproduce:

$ ks init TestApp
INFO Using context "..." from kubeconfig file "..."
INFO Creating environment "default" with namespace "prod", pointing to "version:v1.10.4" cluster at address "..." 
INFO Generating ksonnet-lib data at path '.../TestApp/lib/ksonnet-lib/v1.10.4' 

$ cd TestApp

$ ks pkg install incubator/efk
INFO Retrieved 4 files                            

$ ks generate elasticsearch-kibana kibana
ERROR flag accessed but not defined: name

$ ks generate elasticsearch-kibana kibana --name=kibana
ERROR parse preview args: unknown flag: --name

Additional details:

$ ks version
ksonnet version: dev-2018-10-17T15:51:23-0400
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4

$ cd $GOPATH/src/github.com/ksonnet/ksonnet/ && git rev-parse HEAD
1ad7bbff88cd9eb910899fc7580b2ec446ca7164

$ tree vendor/incubator/
vendor/incubator/
└── efk@40285d8a14f1ac5787e405e1023cf0c07f6aa28c
    ├── efk.libsonnet
    ├── parts.yaml
    └── prototypes
        ├── elasticsearch-kibana.jsonnet
        └── fluentd-es-sidecar.jsonnet

2 directories, 4 files

• Update examples to use env.X
• Update examples to use params.X
• Update examples to include the param and environment extVars
• Remove hard-coded namespace values and remove the namespace param.
• Update version references

Relates to the proposal here.

A ksonnet package for istio seems like it would be very useful.

Haven't found a better place to file this, but in http://ksonnet.heptio.com/docs/tutorial.html it says:

[..] using a mixin library for fluentd (hosted in the official mixins repository).

This links to https://github.com/ksonnet/mixins/tree/master/incubator/fluentd which is missing.

I had addressed this in #41, but that PR is too big to merge so close to launch.

I would check changes ONLY in the incubator/.../*.jsonnet files----not all of them are necessary to update, but the above PR fixes a couple of typos/bugs.

If it's too messy to look at, you can also feel free to just start from scratch though. Whichever is easiest!

There are a lot of branches in this repository that are no longer used. If used, they can probably be moved to individual forks.

Users are reporting the following error:

RUNTIME ERROR: Field does not exist: withVolumes

I ran into a problem when trying to sue the MySql template

When it generates the ConfigMap it seems to add in a key under the data property called configurationFiles:

You can see the line here int he generated example
https://github.com/ksonnet/parts/blob/master/incubator/mysql/examples/generated.yaml#L4

When you try to apply this example to a cluster

apiVersion: v1
data: 
  configurationFiles: 
    mysql.cnf: |
        - [mysqld]
        skip-name-resolve
kind: ConfigMap
metadata: 
  name: mysql
  namespace: default

you get the following response

error: error validating "test.yaml": error validating data: ValidationError(ConfigMap.data.configurationFiles): invalid type for io.k8s.api.core.v1.ConfigMap.data: got "map", expected "string"; if you choose to ignore these errors, turn validation off with --validate=false

But when you remove the line containing configurationFiles: it applies sucessfully

Related to #11, can probably leverage work done in #8.

This is generally useful and will also likely be used in demo(s) for ksonnet.next

Maria, MySQL, Postgres, Redis, Tomcat.

Maria example:
The prototype has a few local variables defined (name, mariaRootPassword, etc.), however the example in examples/maria.jsonnet has none.

e.g.
https://github.com/ksonnet/parts/blob/master/incubator/memcached/parts.yaml