krolaw / zipstream Goto Github PK

Hi,

I came into a situation where I needed to read a zip file from an io.Reader and saw that you had the same issue and wrote this lib to solve it. I was able to use your library, however, when I try to use it with a helper function that I wrote (which just mocks a zip file in a bytes.Buffer) I am failing to read from the zip file.

Not sure whether you're maintaining this or not but here is the code reproducing my issue:
https://play.golang.org/p/nKUpO_nZQz

Thanks!

Is the purpose of this library to read from an io.Reader or to stream read zip archives in chunks?

Hi,

Been getting a panic with a specific file.

panic: runtime error: slice bounds out of range

goroutine 1 [running]:
panic(0x105480, 0xc82000a0c0)
        /usr/local/go/src/runtime/panic.go:481 +0x3e6
github.com/krolaw/zipstream.(*descriptorReader).Read(0xc820012220, 0xc82007c000, 0x1000, 0x1000, 0x1000, 0x0, 0x0)
        /Users/orrikon/workspace/go/src/github.com/krolaw/zipstream/descriptor.go:49 +0x959

Can I email you the file?

Trying to use this library to read a stream of zip files and am encounting an issue with zip files with a data descriptor record.

I have added logging into the example code for the Next method and it is discarding the entire file. I only receive the first file and the remaining content of the stream is discarded due to line 40 [1]

Does this library require the local header having compressed size and uncompressed size set?

It appears to have code for handling the data descriptor but even the unit tests discard the file contents and this results in a unusable library.

[1] https://github.com/krolaw/zipstream/blob/master/reader.go#L40