kristijorgji / goseeder Goto Github PK

On the line referenced, the c.env == "" condition is true for all seeders in the common env, so all seeders get run, that is, including ones that are registered for specific environments.

When I run go run main.go --gseed, I see

Running all seeders...

[categoriesSeeder] started seeding...
[categoriesSeeder] seeded successfully, duration 9.838459ms

[testCategoriesSeeder] started seeding...
[testCategoriesSeeder] seeded successfully, duration 55.890833ms

This seems contrary to the idea that those seeds are registered to only run in the specified environments.

It seems like the c.env == "" should be removed ( as you really need both c.env and seeder.env to be "", which is covered by the following c.env == seeder.env)

Or am I misunderstanding something?

Aside, the c.skipCommon == false at the end of the line could just be !c.skipCommon, right?