kriskennaway / ii-pix Goto Github PK

Hi Kris,

Running the command

python precompute_conversion.py

with Python 3.10 on Windows gave me

ModuleNotFoundError: No module named 'networkx'

https://www.colour-science.org/installation-guide/ describes networkx as optional dependency. So it seems networkx needs to be added to the dependencies in your README. I "fixed" that issue by installing networkx. Then the same command gave me

FileNotFoundError: [Errno 2] No such file or directory: 'data/rgb_to_cam16ucs.npy'

Just as a wild guess I manually created a directory data - and voilà - it worked like a charm. It would be great if you could either have that directory created automatically or add it to the installation commands in your README.

Thanks in advance, Oliver

You mentioned in your documentation that you were looking for a color ordered-dithering algorithm, but had reservations about one that took NTSC bleed into account. I'm not sure you'll find one specifically for that, but maybe it would be worth implementing Joel Yliluoma's arbitrary-palette positional dithering algorithm (https://bisqwit.iki.fi/story/howto/dither/jy/) as an option until you find ways to tweak it.

Ordered dithering is important for anyone attempting animation, as error-diffusion dithering doesn't lend itself to deltas between frames, whereas ordered dithering does and produces stable deltas.

When I'm doing python precompute_conversion.py it gives me the following error:

Traceback (most recent call last):
  File "C:\Program Files\ii-pix\precompute_conversion.py", line 11, in <module>
    import colour
  File "C:\Program Files\Python312\Lib\site-packages\colour\__init__.py", line 67, in <module>
    from .colorimetry import (
  File "C:\Program Files\Python312\Lib\site-packages\colour\colorimetry\__init__.py", line 10, in <module>
    from .spectrum import (SpectralShape, SPECTRAL_SHAPE_DEFAULT,
  File "C:\Program Files\Python312\Lib\site-packages\colour\colorimetry\spectrum.py", line 487, in <module>
    SPECTRAL_SHAPE_DEFAULT = SpectralShape(360, 780, 1)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python312\Lib\site-packages\colour\colorimetry\spectrum.py", line 100, in __init__
    self.start = start
    ^^^^^^^^^^
  File "C:\Program Files\Python312\Lib\site-packages\colour\colorimetry\spectrum.py", line 129, in start
    assert is_numeric(value), (
           ^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python312\Lib\site-packages\colour\utilities\common.py", line 613, in is_numeric
    [float, complex, np.integer, np.floating, np.complex]))
                                              ^^^^^^^^^^
  File "C:\Program Files\Python312\Lib\site-packages\numpy\__init__.py", line 338, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'complex'.
`np.complex` was a deprecated alias for the builtin `complex`. To avoid this error in existing code, use `complex` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.complex128` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: 'complex_'?

The source is a clone of the current main branch.

How do I resolve this?

I'd like to try this little great project. First, to build it I had to install Pillow (v8.1.2) and PIL Tools (v1.0) in addition to the other dependencies mentioned in the Readme. Perhaps, the dependency list is incomplete?

Now, when I run the tool (even without arguments), I get this error:

import: delegate library support not built-in '' (X11) @ error/import.c/ImportImageCommand/1297.
/usr/local/Cellar/ii-pix/20210315/libexec/convert.py: line 22: syntax error near unexpected token `('
/usr/local/Cellar/ii-pix/20210315/libexec/convert.py: line 22: `def main():'

This may be related to my build issue mentioned above. Any idea what is wrong? Using Python v3.9.2, if that matters.

The version history in the readme says versions 1.0, 1.1, 2.0, 2.1, and 2.2 have been released, but the only tag and release is for 1.1. Please add tags and releases for all other released versions.

The README.md has a conflicting story about the command line flags. In the lower body of the .md file, there is an example that shows --lookahead 8 but that flag doesn't appear to exist anymore.

Also, in the Double Hi-Res section, it shows that there's a --palette ntsc flag, but it doesn't make it clear nor show what the other palette options are. Could that be put in?

Last, running python3 convert.py -h only shows the -h option and the positional arguments. I ran it and then was confused because I knew there had to be more.