krisb1220 / minesweeper Goto Github PK

View Code? Open in Web Editor NEW

2.0 1.0 0.0 158 KB

This is a fully complete Minesweeper game. Minesweeper solver coming after!

License: Creative Commons Attribution 4.0 International

JavaScript 88.87% HTML 4.98% CSS 6.15%

games javascript minesweeper minesweeper-js minesweeper-board

minesweeper's Introduction

Minesweeper By Energy Marketing Company

This is a full Javascript Minesweeper full with runnable tests, game logic, and GUI.

⚡ BY KRIS @ ENERGY MARKETING COMPANY ⚡ ENERGYMARKETING.CO ⚡ [email protected] ⚡

Commit Log

COMMIT 53:

Minor changes

Changes

a. Added fast mine on tile double click when flags in cell == number in tile

====================================

COMMIT 52:

Game is FINALLY fully functional!!!! (2/28/2020)

Changes

a. Added cell chain reaction !! b. Fixed bug where if a bomb was double clicked it would not run the highlight function, thus revealing that the cell is a mine. Caused by bomb cells not having a [neighbors] property.

Bug Fixes

a. Fixed timer bug

COMMIT 50:

Bugs mentioned in Commit 45 are still present. Minor bug fixes.

Bug Fixes

a. Fixed errorCan't read property hasFlag of undefined when a number is clicked b. Fixed bug where cell highlighting functionality wasn't working when a number is clicked c. Added functionality to to Easy Dom function $() to accept numbers as ID and Class names

====================================

COMMIT 47:

Bugs mentioned in Commit 45 are still present. Extremely minor changes and some optimizations.

Changes

Below are the changes:

Removed unneeded console.log()'s that were clogging this terminal and slowing the game

Bug Fixes

a. Fixed bug where cell highlight functionality wasn't working after game reset b. Fixed bug where bomb locations weren't being appended to the game.bombLocations array

====================================

COMMIT 46:

Changes

Below are the changes:

1. Refactored code

a. Changed way bomb locations are calculated to avoid collisions b. Removed padding cells in favor of increased boolean logic c. To calculate cells, I added the "neighbors" property to each tile object. d. Added "Tile" class for each tile

2. Added Easy-Dom.js functions to native prototypes

a. Added the changeHTML (element.addHTML) & addHTML (element.addHTML) functions to the HTMLElement prototype b. Added eventListenerAll() to the NodeList prototype ( NodeList.addEventListenerAll() )

3. Added function double click function

a. When a tile is double clicked, it will highlight all neighbors remaining on the board by making them blend with the background (light gray)

Bugs:

hideBoard() is broken

a. After running hideBoard(), click events are broken

Timer function is broken

a. Timer function does not work after second restart, as picture below

Todo:

a. Cell "chain reaction" b. Improved GUI?

minesweeper's People

Contributors

Stargazers

Watchers

minesweeper's Issues

Wrong number calculation (on edge?)

Numbers on the edge are not calculating correctly. Calculating the last 2 cells. Fix by adding an extra cell before & after each row.

Right on Edge

1 over

?

Append numbers to page AFTER button click

The current procedure appends the numbers to each element BEFORE the buttons are clicked. For both cheating & general flow reasons, it should be AFTER the click.

Code needs to be refactored to delete padding cells + add logic for detecting mines in tile 1, x, last, and last-x

Padding cells are no longer needed after the implementation of the following code. Logic for tile 1, tile x, last cell, and last cell - x is needed before padding cells can be deleted.

      //right
      if(field.fieldObject[value.integerLocation + 1].hasBomb && value.integerLocation % field.x != 2 ) {
        bombsInCell++;
      } 

      //left
     if(field.fieldObject[value.integerLocation - 1].hasBomb && value.integerLocation % field.x != 3) {
        bombsInCell++;
      }      


      //top
      if(field.fieldObject[value.integerLocation - field.x].hasBomb) { 
        bombsInCell++;
      } 

      //top right
      if(field.fieldObject[(value.integerLocation - field.x)+1].hasBomb && value.integerLocation % field.x != 2 ) {
        bombsInCell++;
      } 

      //top left
      if(field.fieldObject[(value.integerLocation - field.x)-1].hasBomb  && value.integerLocation % field.x != 3) {
        
        bombsInCell++;
      }       

      //bottom
      if(field.fieldObject[value.integerLocation + field.x].hasBomb) {
        bombsInCell++;
      } 

      //bottom right
      if(field.fieldObject[(value.integerLocation + field.x)+1].hasBomb && value.integerLocation % field.x != 2 ) {
        bombsInCell++;
      } 

      //bottom left
      if(field.fieldObject[(value.integerLocation + field.x)-1].hasBomb  && value.integerLocation % field.x != 3 ) {
        bombsInCell++;
      }

Test

When you click a mined cell's number it returns an error in the console

The error is happening because of the following code in game.js:

function detectClicks() {

  let tiles = document.querySelectorAll(".tile") 

  forEach(tiles, function(tile){
    tile.addEventListener("click", function(event){

      clicked = field.fieldObject[event.target.id]

       if(event.shiftKey) {
         placeFlag(clicked);
       }

       else if(!event.shiftKey){
        clicked.hasBomb ? lose() : mineTile(clicked);
       }
  });
});

and the following code in game-helpers.js from line 128 - 131

	if(!tile.isMined) {
		document.getElementById(tile.integerLocation).innerHTML = "<p class='number'>" + tile.bombsInCell + "</p>";
		document.getElementById(tile.integerLocation).classList.add("tile-mined");
	}

This can be fixed by changing the tile numbering from an ID to a class, then appending the classname to the paragraph holding the number.

showBoard() and hideBoard() broken after GUI added

Rows are not being added, so this happens

krisb1220 / minesweeper Goto Github PK

minesweeper's Introduction

Minesweeper By Energy Marketing Company

Commit Log

COMMIT 53:

Changes

COMMIT 52:

Changes

Bug Fixes

a. Fixed timer bug

COMMIT 50:

Bug Fixes

COMMIT 47:

Changes

Bug Fixes

COMMIT 46:

Changes

1. Refactored code

2. Added Easy-Dom.js functions to native prototypes

3. Added function double click function

Bugs:

hideBoard() is broken

Timer function is broken

Todo:

minesweeper's People

Contributors

Stargazers

Watchers

minesweeper's Issues

Right on Edge

1 over

?

Recommend Projects

Recommend Topics

Recommend Org