krakend / krakend-circuitbreaker Goto Github PK

View Code? Open in Web Editor NEW

12.0 12.0 9.0 80 KB

A collection of curated circuit breaker adaptors for the KrakenD framework

Home Page: http://krakend.io/

License: Apache License 2.0

Go 100.00%

krakend-circuitbreaker's People

Contributors

Stargazers

Watchers

Forkers

cw2030 jorgeavilacardenosa kirinse luis-sousa-pinto yonasbsd luis-pinto-fanduel davron112 i-melnichenko deepcitizen

krakend-circuitbreaker's Issues

Adding a name for the circuit breaker

Hello,

Since sony/gobreaker support naming each circuit breaker, I believe it would be a nice and simple addition to the Config struct, because as it is when a user enables LogStatusChange the log line always reads:
[KRAKEND] 2020/06/24 - 17:40:32.752 ▶ WARNIN circuit breaker named '' went from 'closed' to 'open'

Integrate with Opencensus

Hey, I was wondering if it's at all possible to integrate this into the opencensus exporters. Currently there is no automatic way (aside from parsing the log entries) to find out whether a circuit breaker is tipped or not.

Question about circuit breaker behaviour with `no-op` encoding

Hi,

@alombarte

Krakend version = v2.6.3.

The following config produces a log when the breaker's status changes:

{
    "version": 3,
    "port": 8080,
    "echo_endpoint": true,
    "endpoints": [
        {
            "endpoint": "/test/{var}",
            "backend": [
                {
                    "host": [
                        "http://127.0.0.1:8080"
                    ],
                    "url_pattern": "/",
                    "extra_config": {
                        "qos/circuit-breaker": {
                            "interval": 60,
                            "timeout": 10,
                            "max_errors": 3,
                            "name": "krakend-circuitbreaker",
                            "log_status_change": true
                        }
                    }
                }
            ]
        }
    ]
}

However, when no-op encoding is added, no log is produced when the breaker's status changes:

{
    "version": 3,
    "port": 8080,
    "echo_endpoint": true,
    "endpoints": [
        {
            "endpoint": "/test/{var}",
            "output_encoding": "no-op",
            "backend": [
                {
                    "encoding": "no-op",
                    "host": [
                        "http://127.0.0.1:8080"
                    ],
                    "url_pattern": "/",
                    "extra_config": {
                        "qos/circuit-breaker": {
                            "interval": 60,
                            "timeout": 10,
                            "max_errors": 3,
                            "name": "krakend-circuitbreaker",
                            "log_status_change": true
                        }
                    }
                }
            ]
        }
    ]
}

The docs have this:

There is a small difference in behavior when you use the circuit breaker with no-op encoding vs. the rest of the encodings.

Is this behaviour expected?

Thanks.

Eapache krakend-circuitbreaker does not work.

Hi
the Eapache krakend-circuitbreaker uses "github.com/eapache/go-resiliency/breaker"
but the link changed.
please fix this issue.
Thanks

Off by one error for maxErrors

In my tests I played with very low values for maxErrors (e.g. 2) and I see always maxErrors + 1 hits in my backend, before the cricuit breaker kicks in.

I assume, the reason is, the following line in gobreaker.go (https://github.com/devopsfaith/krakend-circuitbreaker/blob/master/gobreaker/gobreaker.go#L95)

return counts.ConsecutiveFailures > uint32(cfg.MaxErrors)

I assume, the condition should be:

return counts.ConsecutiveFailures >= uint32(cfg.MaxErrors)

krakend / krakend-circuitbreaker Goto Github PK

krakend-circuitbreaker's People

Contributors

Stargazers

Watchers

Forkers

krakend-circuitbreaker's Issues

Adding a name for the circuit breaker

Integrate with Opencensus

Question about circuit breaker behaviour with `no-op` encoding

Eapache krakend-circuitbreaker does not work.

Off by one error for maxErrors

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent