kraken-io / kraken-ruby Goto Github PK

Hi,

I am uploading the images through the URL method provided by Kraken Ruby Gem. However, at times I get this exception and the upload operation fails.

C:/Ruby21/lib/ruby/2.1.0/net/protocol.rb:158:in rescue in rbuf_fill': Net::ReadTimeout (Net::ReadTimeout) from C:/Ruby21/lib/ruby/2.1.0/net/protocol.rb:152:inrbuf_fill'
from C:/Ruby21/lib/ruby/2.1.0/net/protocol.rb:134:in readuntil' from C:/Ruby21/lib/ruby/2.1.0/net/protocol.rb:144:inreadline'
from C:/Ruby21/lib/ruby/2.1.0/net/http/response.rb:39:in read_status_line' from C:/Ruby21/lib/ruby/2.1.0/net/http/response.rb:28:inread_new'
from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:1408:in block in transport_request' from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:1405:incatch'
from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:1405:in transport_request' from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:1378:inrequest'
from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:1371:in block in request' from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:853:instart'
from C:/Ruby21/lib/ruby/2.1.0/net/http.rb:1369:in request' from C:/Ruby21/lib/ruby/gems/2.1.0/gems/httparty-0.13.7/lib/httparty/request.rb:117:inperform'
from C:/Ruby21/lib/ruby/gems/2.1.0/gems/httparty-0.13.7/lib/httparty.rb:545:in perform_request' from C:/Ruby21/lib/ruby/gems/2.1.0/gems/httparty-0.13.7/lib/httparty.rb:492:inpost'
from C:/Ruby21/lib/ruby/gems/2.1.0/gems/kraken-io-0.1.3/lib/kraken-io.rb:39:in block in url' from C:/Ruby21/lib/ruby/gems/2.1.0/gems/kraken-io-0.1.3/lib/kraken-io.rb:67:incall_kraken'
from C:/Ruby21/lib/ruby/gems/2.1.0/gems/kraken-io-0.1.3/lib/kraken-io.rb:38:in `url'

When I use S3 external storage, I must pass AWS_ACCESS_KEY and AWS_SECRET_KEY in params, and send to Kraken API.

But how to know you don't steal my keys?

You can support pre-signed URLs instead. My system will generate a pre-signed URL in 10 minutes expire. So Kraken could upload to my S3 by specifying a path. It's secure more than the current solution.

Please consider this solution.

Your gemspec specifies lib/kraken-io.rb but not any files within lib/kraken-io/, so the requires all fail on load.

require 'kraken-io'
# LoadError: cannot load such file -- rest-client

You might want to add some basic tests - Travis CI would catch this pretty quick