Giter Club home page Giter Club logo

Comments (8)

ionenwks avatar ionenwks commented on June 24, 2024 1

I have a fix at simd-everywhere/simde#1154 but I was unable to test it using qemu 8.2 ; can you confirm that it works for you? Using -march=native and/or -march=bdver2; thanks!

From my end I was able to reproduce with -march=x86-64-v2 -mxop (bdver2 gave illegal instructions at build time without qemu) and can confirm that the PR applied to 0.8.0 fixes it for that scenario, thanks. I could apply it to our Gentoo package until next release.

from kitty.

ionenwks avatar ionenwks commented on June 24, 2024 1

...not that i can confirm that the resulting kitty binary works fine given that gives me illegal instructions without qemu too (I do not have xop, so not that's not surprising). But I'm not too worried there.

from kitty.

kovidgoyal avatar kovidgoyal commented on June 24, 2024

I am confused, the CPU your are using is irrelevant here, this is an
error during build not run. SIMD variants are chosen at runtime not
buildtime. At build time both SSE4.2, and AVX2 code is built which one
is used is determined at runtime. That error comes from a simde include,
so likely some issue between your build toolchain and simde.

from kitty.

ionenwks avatar ionenwks commented on June 24, 2024

Sounds like a simde bug to me, it fails when -mxop is enabled (which is done with -march=bdver2, or -march=x86-64-v2 -mxop) -- Edit: or perhaps due to something else xop enables, haven't looked too closely

simde-features.h ends up hitting some different path and I think(?) it ends up never setting SIMDE_X86_SSE2_NATIVE which leads to m128i being missing (in simde/arm/neon/types.h):

  #if defined(SIMDE_X86_SSE2_NATIVE)
    __m128i m128i;
  #endif

from kitty.

ionenwks avatar ionenwks commented on June 24, 2024

fwiw CPPFLAGS="-DSIMDE_X86_XOP_NO_NATIVE=1" seems to work as a workaround with -march=x86-64-v2 -mxop (haven't tried bdver2 given that makes me hit illegal instructions).

from kitty.

kovidgoyal avatar kovidgoyal commented on June 24, 2024

@BGazotti maybe just remove the -march=bdver2 from your cflags and you should be fine. Do you have any idea where thats coming from? And of course report the issue to simde and hopefully they will fix it.

from kitty.

ionenwks avatar ionenwks commented on June 24, 2024

@BGazotti maybe just remove the -march=bdver2 from your cflags and you should be fine. Do you have any idea where thats coming from? And of course report the issue to simde and hopefully they will fix it.

I came here because I got a downstream bug report on Gentoo, but then they closed it (after seeing the unrelated -mavx2) and came here before I could reply, and most users on Gentoo will do -march=native or =something by default for their entire system.

That aside I applied a workaround for Gentoo, ideally should be looked at in simde though.

from kitty.

mr-c avatar mr-c commented on June 24, 2024

@BGazotti Hello, I'm the SIMDe maintainer and I came across this report.

I have a fix at simd-everywhere/simde#1154 but I was unable to test it using qemu 8.2 ; can you confirm that it works for you? Using -march=native and/or -march=bdver2; thanks!

from kitty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.