kory75 / charactersheetgenerator Goto Github PK

Bootstrap falls back to smallest screen size in case of printing. This is a known issue, and it will be not fixed soon. There are some hacks available but they are messy. As one of the objective is to create original looking printouts. We may need to look for alternative of Bootstrap. I'm opened for any suggestions.

This is a nice article about offline APPs: http://labs.ft.com/2012/08/basic-offline-html5-web-app/
The guy caches the jQuery file, downloads all resources (.css and .js) and stores them in the localStorage. The app repeats the process every time if the user is online (getting the new version) and uses the localStorage resources when offline.

Sorry, It looks like I'm too merge happy. I will not merge anymore the different branches only do pull request on them. So you will able to work on your own branch without it disappearing overnight.

I only store one character sheet at the moment in the html local storage. I store them by field name. Which is will not work with multiple characters. It may safe from collisions with other type character sheets thought, but testing needed.

I have the following idea. We should store data in the local storage in the following format.

[character sheet kod] _ [character id] _ [field name]

Paranoia 2nd edition, 3rd character, character name input field
would be stored like:
PR2_3_character_name

Warhammer Fantasy , 25th character, strength attribute
would be stored like:
WHF_25_strenght

What do you think?

Please Notice: Ideas to use alternative storages should be under a separate ticket.

Maybe a dull note, but I think this is a crucial thing whichever tech we use the delivered product shouldn't be without validation.

as the title suggests, I would suggest to use angular air ember as a framework. It might feels an overkill in first though. But as you continue working on that you will see that you have a better organised code and you can actually do more things faster.

• Angular and Ember provide 2way data binding which means, that you have better control and auto update of fields that hold calculated values.

I found a a blog post on this. Which is a solution for IE, Firefox and Safari. Unfortunately Chrome do not support it.

http://support.lexercise.com/entries/382786-Enable-background-image-printing-in-your-browser

If we popup a window with information on how to print the character sheet properly, that would help the users.

A Dice Roller Singleton would be really useful and could be included to every individual charsheet project.
Let's move the conversation here from the pull request.
As we discussed earlier a method is required that returns a number from any dice formula.
Example:
3d6 returns a number between 3 and 18,
2d10+1d4+3 returns a number between 6 and 27,
etc...

A good idea is to use this js that helps with random.

https://gist.github.com/banksean/300494

Avoid Javascript in your HTML file, it's very hard to maintain. put it in a *.js folder and load it with a script tag instead