kormide / recipe Goto Github PK

In Cake.java L.83 & L.86:

else if (candidates.isEmpty()) {
            throw new RuntimeException("cake does not contain key '" + fullKey + "'");
        }
        else {
            throw new RuntimeException("cannot retrieve ambiguous key '" + fullKey + "'");
        }

when candidates is empty, can you append the full list of cake keys so it's easier to diagnose what went wrong?

When there are more than one candidates, can you append the list of candidates so it's easy to see why its ambigious?

Oven.java L.46

catch (Exception e) {
            throw new RuntimeException("could not bake cake", e);
        }

I'd like to be able to see e's cause message as this is more interesting in debugging purposes than "could not bake cake"

Steps to Reproduce
Key two resources, where one is a suffix of the other, e.g. AB and B. Then, try to get the id of B.

For example:

Cake cake = oven.bake(Recipe.prepare(
   new mySetup1(...).keyed("B"),
   new mySetup1(...).keyed("AB"),
));

cake.get("B") // throws ambiguous key error

Problem
I think the problem is how we determine the list of key match candidates in Cake.java: List<String> candidates = entries.keySet().stream().filter(k -> k.endsWith(fullKey)).collect(Collectors.toList());.

Steps to Reproduce

• In a parameter use a language keyword. For example, public when generating java setups or one of the ones from microsoft/TypeScript#2536 if generating typescript setups

- name: Example
    required:
      - name: public
        type: string
    initializers:
      - params: ["public"]

Expected
A generation failure with the line/column number pointing to the yaml so its easy to figure out which param is incorrect and why

Actual
A compilation failure in the generated code