kordamp / bootstrapfx Goto Github PK

Hi,
Thanks for this library! Would it be possible to add the styling for CombBox? It looks like this by default:

Would be great if you could add this badge to your readme:

Hello BootstrapFX Team,

I've encountered an issue that seems to stem from a compatibility problem between BootstrapFX and ControlsFX, specifically regarding the use of glyphs.

Environment:
BootstrapFX Version: 0.4.0
ControlsFX Version: 11.1.2
Java Version: 17
Operating System: OSX silicon chip

Issue Description:
When using BootstrapFX alongside ControlsFX, the glyphs from ControlsFX are not displayed correctly. Instead of the expected glyph icon, a square is shown. This issue only occurs when BootstrapFX is included in the project. If I remove BootstrapFX, the glyphs display correctly without any problems.

WARNING: Resource "org/kordamp/bootstrapfx/bootstrapfx.css" not found.

I created a button and set the style, but the font not in the center

btn.getStyleClass().setAll("btn", "btn-sx", "btn-primary");

jdk version 11
implementation('org.kordamp.bootstrapfx:bootstrapfx-core:0.4.0')

CheckBoxSkin uses css selectors "box" and "mark"

public CheckBoxSkin(CheckBox checkbox) {
    super(checkbox, new ButtonBehavior<CheckBox>(checkbox));

    box.getStyleClass().setAll("box");
    innerbox = new StackPane();
    innerbox.getStyleClass().setAll("mark");
    ...
}

however mark is being redefined in bootstrap.css as:

mark,
.mark {
  -fx-background-color: #fcf8e3;
  -fx-padding: .2em;
}

this causes the checkbox to be small and the mark is not visible - a workaround is to redefine affected check-box style e.g. from modena in your css file (loaded after bootstrapfx.css)

.check-box:selected > .box > .mark,
.check-box:indeterminate  > .box > .mark {
    -fx-background-color: -fx-mark-highlight-color, -fx-mark-color;
}
.check-box > .box > .mark {
    -fx-background-color: null;
    -fx-padding: 0.416667em 0.416667em 0.5em 0.5em; /* 5 5 6 6 */
}
.check-box:indeterminate  > .box > .mark {
    -fx-padding: 0.666667em; /* 16x16 = 8+8 */
}

First, Thank you for the fantastic implementation!
I just started using it and I saw the label's supported classes don't work. Here's the code:

Label lbl = new Label("some text");
lbl.getStyleClass().setAll("lbl", "h1", "lbl-primary");

but works on the Text class.
Thanks again

Using Panel constructor with title produces label with "panel-title" style, however calling setText() the style is not applied.
A workaround is to call setHeading() passing a Label with "panel-title" added manually so I was wondering if this was intentional?

public Panel(String title) {
    this();
    Label label = new Label(title);
    label.getStyleClass().add("panel-title");
    setHeading(label);
}
public final void setHeading(Node content) {
    this.headingProperty().set(content);
}

/* Label missing style */
public void setText(String text) {
    headingProperty().set(new Label(text));
}

Hi,

would be nice to use this as fully ported bootstrap but at least the spacing CSS classes.

I was wondering how to rotate a panel 90 degrees with showing the CSS as well

Hey.
Are Outline Buttons planned?

I miss them. Can you please add them?

https://getbootstrap.com/docs/4.0/components/buttons/#outline-buttons

Thanks a lot. This is even without it awesome!!

http://jcenter.bintray.com doesn't work now. Instead, please use https://jcenter.bintray.com

$ gradle build
:assemble UP-TO-DATE
:check UP-TO-DATE
:build UP-TO-DATE
:bootstrapfx-core:compassCompileuri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1:in `require':
It seems your ruby installation is missing psych (for YAML output).
To eliminate this warning, please install libyaml and reinstall your ruby.
LoadError: load error: psych -- java.lang.RuntimeException: BUG: we can not copy embedded jar to temp directory
require at org/jruby/RubyKernel.java:937
require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54
at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/psych_jars.rb:2
require at org/jruby/RubyKernel.java:937
(root) at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54
require at org/jruby/RubyKernel.java:937
(root) at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/psych.rb:3
at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
require at org/jruby/RubyKernel.java:937
require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54
(root) at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/yaml.rb:5
(root) at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
require at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:54
load_yaml at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems.rb:624
load_file at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/config_file.rb:328
at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/config_file.rb:197
load at org/jruby/RubyKernel.java:955
at uri:classloader:/META-INF/jruby.home/bin/gem:4
FAILED

FAILURE: Build failed with an exception.

Also if possible can you release the compiled css file?

Hello. I added bootstrapfx libraray to my program. Everything is ok but when I apply this styles my code does not render '\u20bc' symbol on the table column. How can I fix this problem? At now it shows little square

Although I know the basics of bootstrap for web development, is hard to know how to properly add classes to a jfx element. It would be a lot easier if there was a documentation page.

Trying to solve this problem (#14 (comment)) I resorted to plan B: extract the bootstrapfx.css from BootstrapFX's JAR file, copy it in the resources/ folder and use it. This plan B (though is not the correct way) worked as a charm... anyway, in the process I spent some time analyzing the CSS file and I think that I found some strange errors: (I'm not a CSS expert, so I'm not sure if those are really errors, could you please double check my asssumptions?):

For example, in line 168 there is a call to the darken() function:

a.bg-warning:focused {
    --fxbackground-color: darken($color, 10%); }

but reading the JavaFX CSS specification:
https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html
I can't find any darken function (the only reference to darken is as a possible value of -fx-blend-mode)

In line 214 we have this:

.btn:pressed, .btn.pressed {
    -fx-effect: innershadow(gaussian, rgba(0, 0, 0, 0.125), 5px, 0, 0, 3px); }

But according to the specification:
https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html#:~:text=The%20shadow%20Color.-,%3Cnumber%3E%20the%20radius%20of%20the%20shadow%20blur%20kernel.%20in%20the%20range%20%5B0.0%20...%20127.0%5D%2C%20typical%20value%2010.,-%3Cnumber%3E%0A%20%20%20%20%20%20The%20choke
the radius should be a number in the range [0.0 ... 127.0] (without the px unit name)

Finally IntelliJ's editor is also barking at this:

Again, according to the specification, could it be because the selector name should be selected insted of checked?
https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html#checkmenuitem

Thank you for reading till the end! :)

I'd like to use this bootstrap css framework, but accessed through the Gluon SceneBuilder. I see there is an "add css stylesheet" in the menu of the SceneBuilder but I am not sure how this can be combined with the add-on mentioned above?
Also asked on SO: https://stackoverflow.com/questions/61170165/add-a-bootstrap-css-stylesheet-to-gluon-scenebuilder-for-javafx

A great project, that's what I need, thanks a lot :)