Giter Club home page Giter Club logo

phasex's People

Contributors

konraifen88 avatar tabuechn avatar

Watchers

 avatar  avatar  avatar

Forkers

tabuechn

phasex's Issues

Split IController

In IController there are all methods that can be used by UI and other classes. To get the API a little bit more easy we should split the interface into two smaller interfaces

Adding Unit-Tests or change Jackson De-/Serializer

Forgot a value for player and game didn't work as expected after reloading a running gamestate....

Add Unit-Tests to fully check de-/serializer or change classes to use annotations and remove the de-/serializer.

Stacks should not allow to add wrong cards

Currently we can add a blue card to green color stack. This should not be possible and not only checked in controller.

Similar problems in street and pair stack

  • Fixing tests: Splitting them into smaller tests and adding a qualified name. csTest is less significant.

Card number as enum

replacing cardnumbers with enums to be more flexible when adding cards like ace

Externalize the checks if phases are correctly discarded

We should extract the various checks if a phase is correct and use it together.
For Example: Phase 1 & 4 do both checks for phases with 2 different card numbers (Phase 1 triple and Phase 4 quadruple) why not only using one method for both.

Check why github restores last played game automatically

When logging into github account and playing some moves, the last played game is automatically restored (google and twitter works like charm)

How to reproduce:

  1. Log into game with github
  2. Go into single player
  3. Play some moves
  4. Save game
  5. Log out from profile

After now logging into game with github and starting single player the saved game is restored by default.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.