Comments (6)
fgaz
commented on June 3, 2024
fwiw, I'm on linux too and klystrack builds both with and without the patch
from klystrack.
rofl0r
commented on June 3, 2024
it's usually a bad idea to declare a global variable from a header that's included from multiple translation units. the right fix would be to declare only the struct type in the header with a reference to an external instance, which then lives in a single TU. but since @fgaz reports that klystrack builds with the patch, the variable menu_t is probably not even used.
from klystrack.
kometbomb
commented on June 3, 2024
I think it's safe to say that is just a typo and missing the typedef
keyword.
to 24. syysk. 2020 klo 13.44 rofl0r ([email protected]) kirjoitti:
… it's usually a bad idea to declare a global variable from a header that's
included from multiple translation units. the right fix would be to declare
only the struct type in the header with a reference to an external
instance, which then lives in a single TU. but since @fgaz
<https://github.com/fgaz> reports that klystrack builds with the patch,
the variable menu_t is probably not even used.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#295 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIIV2L6MY4UDZ2C6I6PCE3SHMPG7ANCNFSM4QKYA3PQ>
.
from klystrack.
rofl0r
commented on June 3, 2024
I think it's safe to say that is just a typo and missing the typedef keyword.
in this case it would make sense that @distek files a PR with his patch.
from klystrack.
kometbomb
commented on June 3, 2024
Agreed.
to 24. syysk. 2020 klo 22.10 rofl0r ([email protected]) kirjoitti:
… I think it's safe to say that is just a typo and missing the typedef
keyword.
in this case it would make sense that @distek <https://github.com/distek>
files a PR with his patch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#295 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIIV2JVHSZU3LDMZGVGHADSHOKTJANCNFSM4QKYA3PQ>
.
from klystrack.
kometbomb
commented on June 3, 2024
Merged. Thanks!
from klystrack.
Related Issues (20)
- Addition of modifier for transposing in octaves
- Rendering to texture causes flashing HOT 2
- tar.gz issue HOT 2
- compile failed with today's git head master HOT 2
- gitcheck out build HOT 2
- Snap in Ubuntu 19.10 not working HOT 9
- Double free crash when exporting to wav HOT 3
- Keyboard layout ignored in instrument editor HOT 1
- klystrack: ftbfs with GCC-10 HOT 1
- export wav produces an erroneous file HOT 7
- Minor enhancements (or my personal QoL nitpicks, sorry)
- klystrack is now available on FreeBSD
- *.kt file association issues with Windows
- On Linux, with 1000 Hz mouse, klystrack lags when moving mouse around menu HOT 9
- klystrack OSX build quits unexpectedly
- Klystrack snap can't create dotfiles
- Klystrack not recognising themes HOT 6
- Please release 1.7.7 HOT 6
- Crashes with Segmentation Fault, but not when built with debugging options. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from klystrack.