export wav produces an erroneous file about klystrack HOT 7 CLOSED

Ah, I didn't know the code under the abort goto label was supposed to be run even when successful.

I've changed the code in a way that allows that code to run (including ww_finish), but that made the crash reappear. I think that crash happens because the file is closed inside of ww_finish (fclose(ww->file);) AND after export_wav returns (if(export_wav(&mused.song, mused.mus.cyd->wavetable_entries, f, -1)) fclose(f);).

I'll make some modifications and see if that's the issue.

from klystrack.

@farvardin I can confirm the issue you wrote about, Audacity seems to think files exported with the latest master are empty.

The fix I just pull-requested seems to make Audacity see the file content again, at least on my machine.

from klystrack.

It probably doesn't update the header with the correct data size. I did check with Audacity back when I added the feature so need to check what's happening as I don't think there are any changes since that version.

from klystrack.

There of course is a change in 99635da. Successful exports do not call ww_finish so the header is not updated with the sizes and they remain zero. export.c:132 exits the function and only the abort branch will wrap up the wave write.

Hey, @nalquas, is this something that you checked that would cause the crash you fixed - if w_finish is called in both cases (it of course should be called as above)?

from klystrack.

Can you check if it now works as expected?

from klystrack.

@kometbomb @nalquas Yes, I've compiled klystrack with the latest commit, and I can confirm that it's working correctly now, both in audacity and with the flac converter, the wav is ok now!

Thank you for the quick fix!

from klystrack.

from klystrack.