Comments (9)
Hi @SteveMacenski @kunaltyagi ,
I believe there is no major concerns about upstreaming this module to PCL.
Some minor concerns are:
- namespace and class names should be changed
- the code should be updated to follow the recent PCL registration interface convention
I would like to update the code and make a PR on the PCL repository.
from ndt_omp.
Current status: One refactor PR is ongoing: PointCloudLibrary/pcl#4180 (waiting on my review, perhaps by this weekend)
One has been merged, and NDT OMP PR hasn't been created yet (IIRC)
from ndt_omp.
A PR would be welcome.
Please bear in mind a PR before GSoC begins or towards end of GSoC would be preferred. (Reasons being time and a GSoC project on new API to integrate SSE and non SSE code together)
from ndt_omp.
Awesome! That sounds really great. Thanks for that help, it will go a long way.
from ndt_omp.
Any movement here?
We're looking at implementing a NDT-MCL algorithm for Navigation2 to replace AMCL and we'd love to make use of this speed up!
from ndt_omp.
(we're also open for any help / collaboration on that front)
from ndt_omp.
Yes, we have been working on refactoring of the original NDT implementation. After it approved, I'll open a PR for NDT OMP with all the corrections made at PointCloudLibrary/pcl#4180.
from ndt_omp.
@koide3 what's the status of this? Looks like that PR is in so it should be ready?
from ndt_omp.
@SteveMacenski
I made a PR for the multi-threaded NDT, and probably it will be merged after a few review steps PointCloudLibrary/pcl#4277
I'll inform you here once it's merged
from ndt_omp.
Related Issues (20)
- How to assign ndt_omp initial guess transformation between source cloud and target cloud HOT 1
- error : could not find the leaf corresponding to the voxel HOT 1
- error: there are no arguments to ‘omp_get_max_threads’ that depend on a template parameter HOT 1
- Build errors with point type PointXYZINormal or other types existed in pcl
- catkin_make generates so many errors in pcl1.12
- Support ROS2 build HOT 2
- Interpretation of calculateScore Function. HOT 2
- Gradient check method is not compatible with the latest PCL
- The ndt_omp registration time is unstable.
- About the origin of the term "DIRECT7"
- .clang-format seems to be invalid
- Thanks for your work, I have a question about how to konw degradation ahout ndt? HOT 1
- Thanks for your work, I have a question about the degradation of ndt?
- [Registration]ndt_omp running error HOT 1
- How use ndt_omp on my code? HOT 1
- Run alignerror
- Crash app when using scan_matching on ubuntu 22
- Can't found PCL library when using ndt_omp in other catkin packages
- Why do not use std::unordered_map?
- terminate called after throwing an instance of 'std::length_error' what(): vector::reserve
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ndt_omp.