cloneDeep is not cloning all properties when cloning a boolean with false value about mingo HOT 5 CLOSED

Hi @javiercbk

Thanks for reporting this.

Please can you confirm if you are using the latest version of mingo.

I get the expected output using the latest version 2.0.2.

[
{
   "_id":"59c52580809dd0032d75238a",
   "email":"[email protected]",
   "accounts":[
      {
         "createdAt":"2017-09-22T15:00:17.418Z",
         "updatedAt":"2017-09-22T15:00:17.418Z"
      }
   ],
   "accountInfo":{
      "createdAt":"2017-09-22T15:00:17.418Z",
      "updatedAt":"2017-09-22T15:00:17.418Z"
   }
}
]

from mingo.

Actually you're right. I'm so sorry for wasting your time, it must be an error on my side.

I'm wrapping your library as a mongo driver and I'm trying to add support to $lookup aggregation operation (with the concept of named collection). So I came across with this error yesterday and after a quick debug I thought I pinpointed the error in mingo, but now I can see it is my mistake.

Thanks again

from mingo.

I've found the issue, the problem is the cloneDeep function, it is not cloning the property.

To make a quick test, I temporary replaced by lodash cloneDeep implementation

The problem is that the function each does not pickup the property

from mingo.

Pinpointed the issue, when an object has a boolean property with false value, cloneDeep will break and stop cloning properties.

const chai = require('chai');
require('mocha');
const { Aggregator } = require('mingo');

const { expect } = chai;

describe('cloneDeep bug', () => {
  it('should cloneDeep object with false property', () => {
    const oper = [{
      $addFields: {
        accountInfo: {
          $arrayElemAt: ['$accounts', 0],
        },
      },
    }];
    const col = [{
      _id: '59c52580809dd0032d75238a',
      email: '[email protected]',
      deleted: false,
      accounts: [{
        createdAt: '2017-09-22T15:00:17.418Z',
        updatedAt: '2017-09-22T15:00:17.418Z',
      }],
    }];
    const expected = [{
      _id: '59c52580809dd0032d75238a',
      email: '[email protected]',
      deleted: false,
      accountInfo: {
        createdAt: '2017-09-22T15:00:17.418Z',
        updatedAt: '2017-09-22T15:00:17.418Z',
      },
      accounts: [{
        createdAt: '2017-09-22T15:00:17.418Z',
        updatedAt: '2017-09-22T15:00:17.418Z',
      }],
    }];
    const aggregatedCollection = new Aggregator(oper).run(col);
    expect(expected).to.deep.equal(aggregatedCollection);
  });
});

from mingo.

I think I have spotted the bug. This is coming from a function depended on by the cloneDeep implementation. Will fix soon

from mingo.