$round is rounding down to even numbers even when it's above the .5 threshold about mingo HOT 4 CLOSED

Thanks for the report @praoshealth.

Unfortunately, this is one of those problems that is hard to fix comprehensibly given how floating point arithmetic works in JS. See #305 and the question posed on the MongoDB forum.

I think we can find an implementation that will be accurate for the given values, but I suspect there will still be a range of values that will round incorrectly with different decimal places. That said, I am happy to switch to an implementation which we think is better if the error rate is lowest for 4 or fewer decimal places which is reasonable in my view.

The relevant code is here if you wanna take a stab at it.

from mingo.

#348

from mingo.

Thanks for the PR. Happy to merge it with some expanded test coverage. Please include your examples.

    // https://github.com/kofrasa/mingo/issues/347
    [[10.4, 0], 10],
    [[10.5, 0], 10],
    [[10.6, 0], 11],
    [[10.7, 0], 11],
    [[11.4, 0], 11],
    [[11.5, 0], 12],
    [[11.9, 0], 12]

from mingo.

Resolved in 6.4.3. Thanks for the contribution.

from mingo.