Comments (6)
smarth55
commented on May 27, 2024
4
date: '11/(5,[23])' does the job. I added a custom day after thanksgiving with that date, but I can make a PR with the change.
from moment-holiday.
joeycozza
commented on May 27, 2024
2
The day of reckoning is upon us!!!
Hopefully no one has important client facing code relying on this! Our little slack bot tool didn't give us our notifications this morning because of this bug, but that doesn't REALLY matter. Good luck all moment-holiday users!
from moment-holiday.
huangxuewu
commented on May 27, 2024
same issue
from moment-holiday.
AndrewLane
commented on May 27, 2024
FYI I added a test that demonstrates the bug here: #34
I hope it's helpful.
from moment-holiday.
jorgedrr
commented on May 27, 2024
I have the same issue
from moment-holiday.
AndrewLane
commented on May 27, 2024
@smarth55 actually at this point i'm wondering if we should consider this a dead project since I haven't seen commits since 2017.
from moment-holiday.
Related Issues (12)
- minification (?) causes error in gulp build process HOT 3
- NodeJs: Regions is not defined (in strict_mode) HOT 5
- Lacking Webpack integration HOT 12
- modifyHolidays.set() only works on server side HOT 2
- broken? HOT 2
- some issue using this in angular HOT 5
- Incorrect Date for Canadian Thanksgiving
- Add support for French public holidays HOT 1
- add International Women's Day
- TypeError: Cannot read property 'fn' of undefined
- isHoliday() doesn't work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moment-holiday.