Lacking Webpack integration about moment-holiday HOT 12 OPEN

Plus one for this. I'm trying to use this with react, won't work, getting lots of web pack related errors.

from moment-holiday.

Seeing this as well...

from moment-holiday.

Hey, this seems to be a huge problem for us using react can you please show us how to fix this. Thanks

from moment-holiday.

@Anetk we don't really want to modify node_modules as most of the time we delete this before we commit js projects

from moment-holiday.

I have created a fork that is usable via webpack: https://github.com/joeldenning/moment-holiday.

Installation:

npm install --save https://github.com/joeldenning/moment-holiday\#1.5.2-webpack.0

from moment-holiday.

Tried import 'moment-holiday', it seems to work sparingly, depending on the webpack config. Any clues?

from moment-holiday.

Running into this too. Great library, but can't use it due to incompatibility with Webpack.

from moment-holiday.

Also ran into this trying to use in React App.

Is there a workaround?

from moment-holiday.

Cant import

from moment-holiday.

Workaround is to go to node-modules (moment-holiday folder, file:moment-holiday.min.js) and replace:
“undefined”==typeof require||nul===require||require.amd?this.moment:require(“moment”)

with this line:

require("moment")

from moment-holiday.

@kgrosvenor Fork the .min file to your project then, so you can fix the requires there.

from moment-holiday.

@joeldenning thanks for the fork! Also you may want to update your documentation to:

yarn add joeldenning/moment-holiday\#1.5.2-webpack.0

per yarnpkg/yarn#2083 (comment)

Cheers!

from moment-holiday.