Giter Club home page Giter Club logo

Comments (3)

knyar avatar knyar commented on July 26, 2024 1

Good catch! I have added a check for nil label values.

from nginx-lua-prometheus.

hairyhenderson avatar hairyhenderson commented on July 26, 2024

Ok, this was partly my fault - what I left out of the bug report was that I also had a label named protocol (ngx.var.protocol), which was getting set to Inf (!?!?!). I realized this was actually getting set to nil because I chose the wrong variable - shoulda been ngx.var.server_protocol in this case. Anyway, somehow this threw everything off.

This is obviously still a bug though 😉

As a workaround, I made sure that none of my labels were nil, like:

local method = ngx.var.request_method or ""
local status = ngx.var.status or "0"

metric_bytes_sent:observe(bytes_sent, {method, status})

from nginx-lua-prometheus.

hairyhenderson avatar hairyhenderson commented on July 26, 2024

Thanks @knyar!

from nginx-lua-prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.