Giter Club home page Giter Club logo

Comments (5)

knyar avatar knyar commented on July 26, 2024

Could you please clarify what version you are using? Latest version is 0.20221218 but I am not seeing any table lookups on line 387.

from nginx-lua-prometheus.

Jrmyy avatar Jrmyy commented on July 26, 2024
/ # luarocks list

Rocks installed for Lua 5.1
---------------------------

lua-cjson
   2.1.0.10-1 (installed) - /usr/local/lib/luarocks/rocks-5.1

nginx-lua-prometheus
   0.20221218-1 (installed) - /usr/local/lib/luarocks/rocks-5.1

And if I check the file:

/ # cat -n /usr/local/share/lua/5.1/prometheus.lua | sed -n '370,390p'
   370
   371	  if self.lookup_size >= self.lookup_max_size then
   372	    self.lookup_size = 0
   373	    self.lookup = {}
   374	  end
   375
   376	  local t = self.lookup
   377	  if label_values then
   378	    -- Don't use ipairs here to avoid inner loop generates trace first
   379	    -- Otherwise the inner for loop below is likely to get JIT compiled before
   380	    -- the outer loop which include `lookup_or_create`, in this case the trace
   381	    -- for outer loop will be aborted. By not using ipairs, we will be able to
   382	    -- compile longer traces as possible.
   383	    local label
   384	    for i=1, self.label_count do
   385	      label = label_values[i]
   386	      if not t[label] then
   387	        t[label] = {}
   388	      end
   389	      t = t[label]
   390	    end

from nginx-lua-prometheus.

knyar avatar knyar commented on July 26, 2024

Thank you! This does seem to be a bug - currently we only detect nil values for first and last label. I will fix this shortly and will prepare a new release in a couple of days.

from nginx-lua-prometheus.

knyar avatar knyar commented on July 26, 2024

Just released a new version: https://luarocks.org/modules/knyar/nginx-lua-prometheus/0.20230607-1

from nginx-lua-prometheus.

Jrmyy avatar Jrmyy commented on July 26, 2024

Thanks a lot 🥳

from nginx-lua-prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.