knowthen / elm Goto Github PK

There are some minor flaws in that excercise. Basically the solution provided does not match the logic that is suggested.

The exercise descriptions wants you to

[...] set the freeQty of each record using the following logic: Purchases of 5 or more receive 1 free. Purchases of 10 or more receive 3 free.

As I understand this, there are three cases here:

1. with < 5 purchases you get 0 free items
2. with at least 5 and < 10 purchases you get 1 free item
3. with at least 10 and any more than that you get 3 free items

When I looked into the solution the logic behind it seems different, though. The implementation lets you get 3 free items for every 10 and 1 free item for every 5 purchases. The only issue is that if you already got any extra items for having a multiple of 10 purchases, you'll be missing out on another free item in case you have at least 5 more purchases remaining (because the free function checks freeQty == 0).

I'd love to fix it (would be my first PR 🎉 ), but what would be the prefered solution? I think the second way of solving this is a bit more difficult, how about splitting the first exercise into two?

https://github.com/knowthen/elm/blob/master/first-app-improved/Main.elm#L74

I'm working on setting up atom for my elm dev environment (I typically use Sublime and JS) and am attempting to follow these directions, but when I try to add the path for elm-oracle to my language-elm atom package, there is no settings button on my language-elm package and I cannot add the path. Is there something I'm doing wrong here or some way I can fix this?

Hello,
Just start your tutorials and upgrade to elm 0.18 and elm-package.json in "01 functions" for example break the build.
Thank you for your videos!

Hi,

I'm following the beginners course again, I did 2/3 of it in the spring of 2017, bought the full course, but got caught up with other stuff and want to restart.

I'm installing atom 1.20.1 on mac and the needed packages as shown in the instruction video for setting up your dev environment. The problem: when I install linter-elm-make in atom using apm and then fire up atom: there's no settings button for linter-elm make. I've uninstalled the package, uninstalled/reïnstalled the linter, nothing.

I noticed that linter now needs a number of sub-dependencies installed, which I've done. Is there some incompatibility with linter-elm-make and the atom linter package.

On my old mac system I checked the atom setup and there linter-elm-make does show the settings button. I did the exact same setup back then following the instructions, have no idea what's different now. I am not very experienced yet with atom though :-( . The other configuration instructions (path to elm-format) work flawlessly.

If you create 2 plays:

• 1 player2 3pts
• 0 player1 3pts

then delete an old Play so it becomes

• 1 player2 3pts

then add a new play it becomes

• 1 player1 2pts
• 1 player2 3pts

which will mean if you delete or edit either of them then they both get edited. And this could be repeated so that eventually every play get edited/deleted.

Basically when delete is allowed the List.length for an ID generator doesn't work properly.

Normally in this case I keep a nextId in the model and increment it upon adding to the list.

is there any plan to update the material?