klonan / construction_drones Goto Github PK

Error while running event Construction_Drones::on_ai_command_completed (ID 115)
Construction_Drones/script/construction_drone.lua:663: attempt to call global 'drone_wait' (a nil value)
stack traceback:
Construction_Drones/script/construction_drone.lua:663: in function <Construction_Drones/script/construction_drone.lua:652>
(...tail calls...)
core/lualib/event_handler.lua:47: in function <core/lualib/event_handler.lua:45>

When playing without a player character ("god mode"), the drones return to the correct position. But they are not correctly despawned. Instead they rotate in place for a few seconds, until they eventually disappear.

I'm using mod version 0.6.11.

Bulk Rail Loader utilizes a proxy entity for construction. During on_built, a bunch of other entities are created and finally the proxy entity is destroyed. As to why, BRLs can be built in different directions, but the main entity of a BRL is a container, which cannot have a direction.

This works fine, except that Construction Drones isn't content with just checking success from the revive() call, but also checks if the returned entity is non-nil. Since the entity was destroyed as part of the revive event handler, nil is returned along with true.

Construction Drones is treating this as a failed attempt to build the entity, so the drone returns to the player and gives the item back, leaving the player with an extra item. It should be enough to just check success.

factorio-current.log

I was placing some rails with my drones. I had placed 3 blueprints next to each other. The first 2 were completed, the 3rd was partially complete. I undid the last blueprint (which caused half of it to be marked for deconstruction) and then immediately placed another blueprint overlapping where it used to be. At this point, the crash happened.

Update 18.45 drones build all the drawings, but they only collect small objects (walls, tapes, manipulators) and such objects as an oil plant, an assembly machine or ventilation, he does not pick up, leave the inventory and stand looking at them.
and the sound also hangs, like they are constantly driving from the inventory to the collection object

Bots just stop right in front of the tank, just sit there and won't get back into inventory.

Some mods such as nicefill attempt to index the item field of the on_robot_built_tile which is left unset by construction drones.

[Devs must be inactive, no answer for 4 months. Redacted.]

Not sure on whos end this is, but when replacing a Yellow belt with Red belt next to a belt balancer, game crashes with above message.

Factorio: 0.18.27
Construction_Drones: 0.6.1
cargo-ships_0.0.54
beautiful_bridge_railway_0.18.1

When loading the game with above mods, the below message pops up

If you do have items in your inventory to construct a blueprint that has upgradeable items you will be able to get free upgrades using it. To "benefit" from this setup the blueprint so that bots will begin to swarm (bigger distances makes this easier). If you upgrade ghosts which bots have already swarmed for they will construct the upgraded items despite you not having it in your inventory.

1. Have Construction Drones in your inventory
2. Have yellow belts in your inventory
3. Place a ghost for some yellow belts some distance away
4. See that bots swarm to construct those ghost
5. Upgrade ghosts before bots arrive

Forum thread: https://mods.factorio.com/mod/Construction_Drones/discussion/5f2c50853f87ac17645644fd

I also checked and drones seem to stuck while deconstructing rocks, just like in the #18 .

For some reason the drones seem to do "something" to AAI zone markers.

In the image above they are trying to build a power expansion further north but have to cross this AAI Zone marking and seem to need to use a pinkish beam on them (I'm not sure what that signifies as usually I only see red or green beams).

Hope you can fix this strange behavior (Also I love the mod especially early game it is super duper useful!)

Hey @Klonan,

Sorry to reach out here, but do you also own https://mods.factorio.com/mod/Laser_Beam_Turrets?

If so, would you update it to support 0.17.x? ❤️

I do not see a repo for submitting a PR.

There is special logic to copy over the input/output type when upgrading a loader, but this code doesn't check for the recently introduced loader-1x1 type. This breaks any mod entity using this type (e.g. Miniloaders) when upgrading.

In Factorio 18.43, the drones will not build. They move to the location but then sit there doing nothing. Revert to 18.42 and they work again.

https://mods.factorio.com/mod/Construction_Drones/discussion/5f2c50853f87ac17645644fd