Package.json has type: module but main still points at commonjs about a11y-dialog HOT 5 OPEN

Here's a related discussion in the vitest repo vitest-dev/vitest#4233

from a11y-dialog.

If anyone else runs into this, I worked around this by adding an alias to my vite config:

alias: {
  'a11y-dialog': path.resolve(__dirname, './node_modules/a11y-dialog/dist/a11y-dialog.esm.js'),
},

from a11y-dialog.

Hello Brian, and thanks for opening an issue. 👋

I must say this is the part of maintaining a package I am really unexperienced with, and I am always terrified of breaking things by touching the entry points or the bundling system. I recall having to release several hotfixes after v8 to have something that works. 😓

If you are pretty confident with the exports approach, you could consider opening a MR and I’ll happily review it. Otherwise, maybe we can just add your workaround to the docs. What do you think?

from a11y-dialog.

Yeah I agree touching exports can be scary!

I'm happy to send a MR when I get a chance. I think the biggest risk is that a user might be reaching into the package to grab some internals, and the exports change makes those internals no longer public. So the safest bet is to make sure that all files that are currently in the dist folder remain accessible. You can always lock that down further in a major version update, but this would be the safest bet to keep it a minor version bump.

from a11y-dialog.