Giter Club home page Giter Club logo

Comments (4)

KittyGiraudel avatar KittyGiraudel commented on September 13, 2024

Interesting. I’d like @Heydon and @ffoodd opinion. :)

from a11y-dialog.

ffoodd avatar ffoodd commented on September 13, 2024

I totally agree, and even if it's pretty subtle, so does WAI: Making a dialog modal.

On the third paragraph it says that "focus should be set to the first tab focusable element within the dialog", what you did by setting it on the first input. But two sentences later: "There must be some element within the dialog which can accept focus in order for the screen reader to speak the dialog title and information when it is opened."

And announcing the dialog title should obviously happen before any other interaction inside the modal (IMO). This is what's done on the Athena ICT example and many other examples.

So for all these reasons I think @martinkz is right :)

from a11y-dialog.

KittyGiraudel avatar KittyGiraudel commented on September 13, 2024

Okay, then let’s add tabindex=0 to the dialog title.

from a11y-dialog.

KittyGiraudel avatar KittyGiraudel commented on September 13, 2024

Should be done with 59c452e and cb36732.

from a11y-dialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.