Comments (4)
Interesting. I’d like @Heydon and @ffoodd opinion. :)
from a11y-dialog.
I totally agree, and even if it's pretty subtle, so does WAI: Making a dialog modal.
On the third paragraph it says that "focus should be set to the first tab focusable element within the dialog", what you did by setting it on the first input. But two sentences later: "There must be some element within the dialog which can accept focus in order for the screen reader to speak the dialog title and information when it is opened."
And announcing the dialog title should obviously happen before any other interaction inside the modal (IMO). This is what's done on the Athena ICT example and many other examples.
So for all these reasons I think @martinkz is right :)
from a11y-dialog.
Okay, then let’s add tabindex=0
to the dialog title.
from a11y-dialog.
Should be done with 59c452e and cb36732.
from a11y-dialog.
Related Issues (20)
- ES6-only version HOT 1
- Public property shown not defined in the typescript definition file d.ts HOT 3
- Reconsider using aria-hidden instead of aria-modal HOT 6
- Dialog doesn't prevent tabbing around the page behind the dialog HOT 3
- [Questions] questions from a curious student HOT 5
- Docs: interface for 'show' event listener callback is incorrect HOT 2
- `description` meta thrown off by <code> tag and < HOT 3
- Consider stopping propagation on capturing the ESC keydown HOT 7
- Usage inside custom component (<template>) HOT 3
- How does it compare with the <dialog> element? HOT 1
- How to get distribution files HOT 2
- Option to disable focus trap completely ? HOT 5
- Document-level click event listening breaks inside web components HOT 15
- keyboard events inside custom element w/stenciljs HOT 2
- Feature request: Option to disable Focus Restoration HOT 3
- Package.json has type: module but main still points at commonjs HOT 6
- Consider implementing the 'shown' and 'hidden' events to facilitate animations HOT 2
- Can the Popover API be utilized in a11y-dialog? HOT 2
- Custom event to assist with escape key conflicts HOT 4
- Investigate whether pnpm would improve development workflow HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from a11y-dialog.