artus's People
artus's Issues
E/gamma energy corrections implementation missing
For e/gamma there is no implementation for residual scale and smearings corrections available. This should be implemented. Naturally, I recommend to do this in the placeholder function AdditionalCorrections
in the ElectronCorrectionsProducer
.
ROOT6 workaround branch for HarryPlotter
Dear Daniel, all,
Is this branch still needed?
Or can we delete it?
https://github.com/KIT-CMS/Artus/tree/harry_workaround_segfault_ROOT6
Cheers,
Artur
Run 2 Rochester Corrections with UL
Run 2 Rochester Corrections for UL campaign https://twiki.cern.ch/twiki/pub/CMS/RochcorMuon/roccor.Run2.v4.tgz need to be added into the code /Utility/interface/RoccoR.h and /Utility/src/RoccoR.cc.
Furthermore, it is not necessary anymore to differentiate the treatment of 2016 Rochester Corrections.
Also, there might be some changes in the recommended methods to compute the scaleFactors
, since the methods
//old, should only be used with 2017v0
double kScaleFromGenMC(int Q, double pt, double eta, double phi, int n, double gt, double w, int s=0, int m=0) const;
double kScaleAndSmearMC(int Q, double pt, double eta, double phi, int n, double u, double w, int s=0, int m=0) const;
double kScaleFromGenMCerror(int Q, double pt, double eta, double phi, int n, double gt, double w) const;
double kScaleAndSmearMCerror(int Q, double pt, double eta, double phi, int n, double u, double w) const;
provided are deprecated and still in use in /KappaAnalysis/src/Producers/MuonCorrectionsProducer.cc.
OnLumi fails on some data skims
For a handfull of data skims, it seems that for a portion of events at the beginning of the file the onLumi
code in ElectronCorrectionsProducer is skipped and executed only for the next portion of events. In this call the objects in the Lumi tree of the file are bigger than they should be (presumably integer multiple), which leads to assertion error in the getIdNamesMap
function.
Electron Correction uncertainties need rerun of whole setup
It would be much nicer, if the variations would be separately saved as weights in the NTuple. This would only need adjustments in the postprocessing rather than producing new dedicated NTuples.
Implementation for Rochester Corrections for UL18 and UL16 is missing
Applied Rochester Corrections for UL all years and 2016 behaviour unclear
Artus/KappaAnalysis/src/Producers/MuonCorrectionsProducer.cc
Lines 28 to 42 in cb58705
doesn't cover all the possible run periods. This needs to be fixed immediately!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.