kiskolabs / heroku-buildpack-calibre Goto Github PK

I think that this line

After executing:

heroku run /bin/bash
echo $PATH

I get /usr/local/bin:/usr/bin:/bin (no /app/calibre).

I think the proper way to add something to the path is shown here https://github.com/heroku/heroku-buildpack-php/blob/cd2d13992b72d049aa270d4b745aae6329e0c037/bin/compile#L115 and described here https://devcenter.heroku.com/articles/buildpack-api#example-profile-d-mybuildpack-defaults-sh

Compile error ImportError: No module named site

Thank your for creating this builpack - it helped me a lot!

What do you think about an option to specify the exact version of Calibre which should be installed? When using this buildpack Calibre is installed from scratch on every deploy and as a new version of Calibre is released, it will be automatically "upgraded".

It looks like the linux-installer.py provides a way to install a different version than the latest one - https://github.com/kovidgoyal/calibre/blob/0cb677fb90f2302a3b8fea48b60b946207f429b2/setup/linux-installer.py#L16 We could set CALIBRE_INSTALLER_LOCAL_URL to http://download.calibre-ebook.com/2.62.0/calibre-2.62.0-x86_64.txz (for example).

The value of CALIBRE_INSTALLER_LOCAL_URL could be read from Heroku config variables as described here https://devcenter.heroku.com/articles/buildpack-api#buildpack-api -> ENV_DIR.