Test refactoring about killbill HOT 4 CLOSED

The proposal is the following:

Issue 1: Most tests should use Guice-- unless maybe a very simple unit test that does not require anything.
Each maven module (account, invoice,...) would create its own modules (probably one for slow and one for fast tests) and all tests should use the same module

Issue 2: Having mock classes for each outside module-- for example when invoice needs to call account its tests-- would be clean but requires quite a bit of work, and also a lot of maintenance when changing those APIs. The suggestion is therefore to use Mockito to mock those API calls.

Issue 3: Per module mock classes are advisable-- for instance a DAO layer could have an in memory implementation for tests; however this also requires some work, and so we would leave each module decide whether to use Mockito or materialized mock class. However a given module should be consistent across its tests and always use the same. That is either Mockito or existing mock classes.

from killbill.

Next pass is:

• Fix modules left (beatrix, server, tenant, meter, analytics)

from killbill.

Remaining tasks will be:
. Fix start/stop sequences -- they all look similar
. Decide on mock module versus real class to use; for instance should account use real Tag or mock Tag?
. System properties for tests (set at startup versus) resource file configuration

from killbill.

This has ben completed

from killbill.