Giter Club home page Giter Club logo

Comments (2)

reshmabidikar avatar reshmabidikar commented on June 19, 2024

The following tests reproduce the issue:

Further analysis:

  • UTC time zone - Subscription start date is 2024-02-21T6:00 UTC. Usage is recorded at 2024-02-21T6:05 UTC. Invoice target date is 2024-02-21. Usage is retrieved for the billing period between 2024-02-21T6:05 UTC to 2024-02-21T23:59 UTC. Since the recorded usage is during this period, the usage is included in the current invoice.
  • PST time zone - Subscription start date is 2024-02-21T6:00 UTC. (This is 2024-02-20T10:00 PST). Usage is recorded at 2024-02-21T6:05 UTC). Invoice target date is 2024-02-20 (date in user's time zone). Usage is retrieved for the billing period between 2024-02-21T6:05 and 2024-02-20T23:59. Since the recorded usage is not during this period, it is not included in the current invoice.

The PST behavior may not be correct. The optimizedStartDate is taken to be 2024-02-21T6:00 (which is in UTC) while the targetDateMaxis taken to be 2024-02-20T23:59 which is in PST at this line. Shouldn't the dates be converted to the same time zone before retrieving the usages?

from killbill.

reshmabidikar avatar reshmabidikar commented on June 19, 2024

Update:The issue occurs for an account in PST timezone only when the PST and UTC time falls on different days:

from killbill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.