Comments (2)
The following tests reproduce the issue:
- testInArrearUsageCreateCancelUTC - Account in UTC time zone
- testInArrearUsageCreateCancelPST - Account in PST time zone
Further analysis:
- UTC time zone - Subscription start date is
2024-02-21T6:00 UTC
. Usage is recorded at2024-02-21T6:05 UTC
. Invoice target date is2024-02-21
. Usage is retrieved for the billing period between2024-02-21T6:05 UTC
to2024-02-21T23:59
UTC. Since the recorded usage is during this period, the usage is included in the current invoice. - PST time zone - Subscription start date is
2024-02-21T6:00 UTC
. (This is2024-02-20T10:00 PST
). Usage is recorded at2024-02-21T6:05 UTC
). Invoice target date is2024-02-20
(date in user's time zone). Usage is retrieved for the billing period between2024-02-21T6:05
and2024-02-20T23:59
. Since the recorded usage is not during this period, it is not included in the current invoice.
The PST behavior may not be correct. The optimizedStartDate
is taken to be 2024-02-21T6:00
(which is in UTC) while the targetDateMax
is taken to be 2024-02-20T23:59
which is in PST at this line. Shouldn't the dates be converted to the same time zone before retrieving the usages?
from killbill.
Update:The issue occurs for an account in PST timezone only when the PST and UTC time falls on different days:
- testInArrearUsageCreateCancelPST1 - PST and UTC on different days, so does not work as expected
- testInArrearUsageCreateCancelPST2 - PST and UTC in the same day, so works as expected.
from killbill.
Related Issues (20)
- Monitor background threads via healthcheck
- Multiple usage invoice items are created on plan change HOT 3
- Invoice plugins not called on commit/void
- Invoice plugins not called on refund HOT 2
- How can you kill this if someone has used all your information and sent this after all my personal accounts I almost broke help please HOT 2
- Encountering Tomcat SSL configuration issue HOT 1
- Subscription/bundle level entitlement status? HOT 2
- Reusing Written Off draft invoice
- Retrieve invoice by number returns incorrect balance for written off invoice HOT 1
- Create Subscription After Successful Payment HOT 2
- Plan Price Changes - Update System Logic
- Relax invoicing rules around additional items received from plugins HOT 2
- Verify behavior of invoicing system with DAILY billing period HOT 2
- Ability to link existing Authorization transaction with an invoice /use it for payment HOT 1
- Ability to better detect or override DBEngine HOT 1
- Capacity Usage Price Override - not supported
- KillBill allows recording a usage with the wrong unit type HOT 1
- Ability to control invoice#id HOT 1
- Invalid catalog passes validation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from killbill.