Giter Club home page Giter Club logo

Comments (3)

sbrossie avatar sbrossie commented on September 23, 2024

We should check all the code paths where we call DefaultInvoiceDao#createInvoices with a null existingInvoiceMetadata parameter, and either check whether those are:

  1. Already available to the caller - and up to date
  2. Not available, but we could do one query to populate the cache, or as an alternative, have more logic in the ExistingInvoiceMetadata class to load items on a per invoice basis when we detect there are absent.

from killbill.

reshmabidikar avatar reshmabidikar commented on September 23, 2024

A few questions:

  1. From what I understand, ExistingInvoiceMetadata represents a cache of invoice and invoice items. Since the invoice items cache is empty, each invoice item is fetched from the DB, causing a performance issue. Does that sound right?

  2. Does the following refer to a cache of existing invoices for a particular account?

The idea behind ExistingInvoiceMetadata was to provide a cache of invoices and items.

from killbill.

sbrossie avatar sbrossie commented on September 23, 2024

From what I understand, ExistingInvoiceMetadata represents a cache of invoice and invoice items. Since the invoice items cache is empty, each invoice item is fetched from the DB, causing a performance issue. Does that sound right?

Yes.

from killbill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.