I am currently having trouble building the Stripe plugin with IntelliJ IDEA 2021.1. As there is a .idea folder in your repositories, it looks like you are also using IntelliJ IDEA.

I have recently upgraded to IntelliJ 2021.1 and now building a project inside the IDE does not work anymore. It seems like Jetbrains changed something internally which now triggers a bug in an older version of manifold that is used in killbill-oss-parent.

Some more information can be found here: https://youtrack.jetbrains.com/issue/IDEA-266798. I don't know if Jetbrains will change anything on their side.

Upgrading manifold from 2020.1.45 to 2021.1.11 resolved the issue for me. But I only tested it to compile the Stripe plugin. I don't know if upgrading manifold will lead to problems in any of your other projects.

It would be great if you could consider upgrading manifold next time you are upgrading your dependencies.

Could we use one with a smaller footprint?

Related: #126

This is sub-task from this: #552 . Ideally work right after #619 completed.

TBA

Details will added if needed, but TDLR: Once forked repository build successfully, some steps like in #619 would be needed.

See:

• #374
• #411
• #420
• #431

Note: need to upgrade to Jetty 11 as part of this.

The dry-run feature is a Pro feature for Flyway:

• flyway/flyway#87
• https://flywaydb.org/documentation/dryruns

Because of this, we've implemented our own dry-run on top of Flyway 4.0. Work is needed to port the code to the latest version.

Note: it looks like some folks are relying on this outside of Kill Bill (https://stackoverflow.com/a/38086304).

Currently, each Kill Bill repository has an automatic way of releasing itself (release.yml github workflow). What's time consuming is the ordering of releases that is necessary.

We're not expecting that we automate all of release process (what if there are failures in the middle or infinite loops...), but at least, for example: each time killbill-platform released, it automatically triggers a release of killbill-oss-parent with the new version of killbill-platform.

Some idea (from Pierre):

There is an event that can be triggered across repos: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#repository_dispatch So one release could trigger (in theory) the next.

We also need to update via script the version of repo X in the killbill-oss-parent workflow (ideally the new version is sent in the repository_dispatch event and passed here:

killbill-oss-parent/.github/workflows/release.yml

Line 11 in 125da2c

description: 'New killbill-base-plugin version'

).

.... maybe there is another way of doing it... Like doing all releases from a "central" repo, just like the ci job is doing here: https://github.com/killbill/killbill-oss-parent/blob/125da2cf399802378cf1349bbd3afc9c24503927/.github/workflows/ci.yml

When working on this, we may need run github action locally.

The snakeyaml dependency needs to be updated to 2.0. The current version (1.33) has some vulnerabilities which is causing an issue for some customers.

We've had to ignore some libraries updates over the years due to various upstream blockers, see

Once the various pending PRs from dependabot have been merged, let's do a 2022 pass, to see if some of these ignore entries can be removed.

Some of these are pre-requisite for Java 11 support.

Wave 1

• Jackson to 2.11.1. Release notes
• Guava to 29.0. Release notes. Transitive dependencies have changed, something to look at.
• Guice to 4.2.3. Release notes. Transitive dependencies have changed (e.g. multibinding), something to look at.
• slf4j to 1.7.30. Release notes
• Ehcache to 3.8.x. Release notes
• Jetty and jetty-maven-plugin to 9.4.x
• Various Maven plugins affecting the build
• Mockito
• com.ning:async-http-client to org.asynchttpclient:async-http-client

Wave 2

• HikariCP to 3.4.5. Release notes
• MariaDB to 2.6.x. Release notes
• Shiro to 1.6.x. Release notes. See #36
• Jooby to 2.x See #40
• Jooq (plugins generated code must be re-generated)
• Snowflakes in various repos, such as commons-compress in platform and Kill Bill or flyway in Kill Bill (see #39)

Wave 3

• Metrics to 4.1.x. See #37
• Jersey to 2.x. This is a project (migration guide, Guice wiring must be re-done, Swagger wiring might need to be updated). Related: javax.servlet-api to 4.x (we'll tackle this separately)

Wave 4

• Felix to 7.x. This is a project

See

This might help for killbill/killbill#1878.

Code to upgrade:

• jdbi. Note that there is already code for ST4 it seems (https://github.com/killbill/killbill-commons/blob/07940775e6c51f26b05e9e136c4ff1e43f113cc6/jdbi/src/main/java/org/skife/jdbi/v2/sqlobject/stringtemplate/ST4StatementLocator.java) - to be investigated 🤔
• analytics-plugin

We define maven-clean-plugin here. But AFAIK, we not use it anywhere. My understanding is that, to "use" that plugin, we should define it in build/plugins/plugin. So far, we just declare/define it in build/pluginManagement/plugins/plugin. I checked any other project that may use it, but I can't found any. The only project that use it is api-pojos, but this project not using this parent pom.

The current version of the log4jdbc library does not implement the getSchema / setSchema methods. This causes an issue with the analytics plugin. See killbill/killbill-analytics-plugin#152.

Once this library is updated, we would need to update its version in oss-parent.

Also see arthurblake/log4jdbc#99

This is a sub-task from this: #552

Since PostgreSQL update more important (needed to update jooq, also it's old already), we'll cofus with it as the first step:

Step A: Update killbill-commons

1. Change killbill-commons to update testing-postgresql-server with embedded-postgres.
2. Use killbill-commons local SNAPSHOT in killbill-platform and killbill
3. Test them, once everything Ok, send PR

Step B: Update killbill-platform

1. When killbill-commons available in sonatype, update killbill-platfrom from testing-postgresql-server to embedded-postgres.
2. Use killbill-platform local SNAPSHOT in killbill, and test them.
3. Use killbill-platfrom local SNAPSHOT in killbill-stripe/braintree-plugin, update jooq version, and test them.
4. Once everything Ok, send PR

Step C: Update killbill-oss-parent

We have killbill-commons and killbill-platform with up-to-date embedded-postgres migration, so:

1. Update killbill-oss-parent with up-to-date killbill-commons and killbill-platform, build locally.
2. Use killbill-oss-parent local SNAPSHOT in killbill-stripe/braintree-plugin, update jooq version, and test them.
3. Use killbill-oss-parent local SNAPSHOT in killbill, and run test, and manual test with plugins installed, if needed.
4. Once everything Ok, send PR

Last Step

1. Once everything Ok, send PR for killbill with up-to-date killbill-oss-parent
2. Delete killbill-embeddeddb-postgresql in killbill-commons It's still used as test-jar dependency

Dependencies:

• Upgrade Guice: https://github.com/google/guice/wiki/Guice501
• killbill/killbill-commons#95 (at which point, cglib should be banned in the base pom.xml)

This is blocked by:

• HikariCP (brettwooldridge/HikariCP#335).
• metrics-guice (https://github.com/palominolabs/metrics-guice). Probably needs to be rewritten (unmaintained).
• dropwizard-metrics-influxdb (iZettle/dropwizard-metrics-influxdb#84).

See https://groups.google.com/g/killbilling-users/c/ERUfKsacHlY/m/MtOpjYpLAQAJ

There are some deprecated configuration in github CI. Take a look here: https://github.com/killbill/killbill-oss-parent/actions/runs/3666893119 .

Link above refers to github action, and sometimes it disappear after a while, so here are more info from blogs, and screenshot:

• actions/runner-images#6399
• https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
• https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

TODO:

• Update to latest versions of org.osgi.* components
• Update to latest Felix components
• For testing, build the latest Stripe plugin and verify the tutorial still works: https://docs.killbill.io/latest/stripe_plugin.html
• Verify plugin APIs still work: https://docs.killbill.io/latest/plugin_management.html
• Verify KPM bundle still works: https://docs.killbill.io/latest/plugin_development.html#_kill_bill_plugins_2 (make sure to build the latest KPM bundle with latest OSGI version: https://github.com/killbill/killbill-platform/tree/master/osgi-bundles/bundles/kpm)

As part of this, remove the hacks in place:

• https://github.com/killbill/killbill-commons/pull/98/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R165
• https://github.com/killbill/killbill-platform/pull/77/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R180
• https://github.com/killbill/killbill-platform/pull/77/files#diff-499f9785514a81b7e7e70d390700ba3314a034a444221a5b83f9c7cd05426340R370
• https://github.com/killbill/killbill-platform/pull/77/files#diff-236627b52f884d06f0d0879137f919a4e74e9f6841176cf62c4efa6a2ccbe509R46
• https://github.com/killbill/killbill-platform/pull/77/files#diff-236627b52f884d06f0d0879137f919a4e74e9f6841176cf62c4efa6a2ccbe509R119
• https://github.com/killbill/killbill-plugin-framework-java/pull/50/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R215
• https://github.com/killbill/killbill/pull/1517/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R75

3.2.1 isn't on Maven Central.

See also #21.

Currently, we're using embedded database server for MySQL and postgreSQL. Unfortunately, those library in "public archive" state, so it is unlikely that we can even send a PR: There's case that we need to update postgreSQL version to test make sure we able to upgrade JOOQ library. Current testing-postgresql-server version doesn't support fetch ... row only statement, where JOOQ 3.15.x will use that statement.

So this leave us with:

1. Use testcontainer. Problem is experience tell me that this is slow compared to use local/installed/embedded.
2. Fork those embedded server library to killbill-commons.

Current plan: Lets use testcontainer in smaller project like stripe/braintree plugins. If it’s too slow/painful, maybe we just fork them.

We had this updated plan, but a comment section is not a quite right place to put a (bigger) plan, so I decided with 2 sub-tasks:

• #619
• #620

This is causing several plugins keep using jooq 3.13.x:

• https://github.com/killbill/killbill-stripe-plugin/blob/ad486fd659ddd93b720f674774de2db4c07d140b/pom.xml#L117

• https://github.com/killbill/killbill-braintree/blob/04b50da8cf96fd94b3d42a0b26af641bff0cb1e1/pom.xml#L108

• https://github.com/killbill/killbill-stripe-plugin/blob/9a091f725c7b0e61a93322e0d2c4f5a6a948062c/src/main/java/org/killbill/billing/plugin/stripe/dao/StripeDao.java#L214

• https://github.com/killbill/killbill-braintree/blob/ef8617d6b10e1bca0586e03620da49601b336f1e/src/main/java/org/killbill/billing/plugin/braintree/dao/BraintreeDao.java#L163

This is because in 3.14.0+, returning() in MariaDB will use insert .... returning statement. Solution would be:

• Not using returning()
• Change dialect from MariaDb to MySQL.

Because of https://issues.apache.org/jira/browse/SHIRO-679 (duplicate classes across artifacts), we cannot upgrade until 2.0.0 is released (apache/shiro#236).

Once we've upgraded, do we still need the forked classes in Kill Bill?

Also need to remove this config:

Related:

• https://issues.apache.org/jira/browse/SHIRO-435
• https://issues.apache.org/jira/browse/SHIRO-510
• https://issues.apache.org/jira/browse/SHIRO-540

Jooby 2.x is a significant rewrite. The major breaking change is that there is no more Servlet support, which is a blocker for us.

Here are my notes from a quick investigation.

1. org.jooby.Result and org.jooby.Results are gone, the new io.jooby.Context should be used instead.

@Singleton
@Path("/something")
public class SomethingResource {
    @GET
    public Result getSomething(final Optional<String> maybeSomething) {
        return Results.ok(...);
    }
}

becomes

@Singleton
@Path("/something")
public class SomethingResource {
    @GET
    public void getSomething(final Optional<String> maybeSomething, final Context context) {
        context.setResponseCode(StatusCode.OK);
    }
}

2. Jooby#use(config) has been removed: instead, we need to create a new environment (https://jooby.io/#configuration-custom-environment). Maybe something like that (untested):

    public PluginApp build() {
        final PluginApp app = new PluginApp(jackson, services, routeClasses);
        final Environment origEnv = app.getEnvironment();
        final Environment newEnv = new Environment(origEnv.getClassLoader(),
                                                   this.config.withFallback(origEnv.getConfig()),
                                                   origEnv.getActiveNames());
        app.setEnvironment(newEnv);
        return app;
    }

3. org.jooby.Sse has become io.jooby.ServerSentEmitter
4. org.jooby.mvc.Local has become io.jooby.annotations.ContextParam
5. There is no injection framework in 2.x. Guice has been replaced with a simple hash map service registry. Extra work is needed to integrate Guice again: https://jooby.io/#dependency-injection-guice

As part of the upgrade, we should add a few tests (https://jooby.io/#testing) in our base framework, to help with such upgrades in the future.