NPE in BusinessTagModelDao about killbill-analytics-plugin HOT 4 OPEN

We are experiencing the same error... looks like the __PARK__ tags w/ tag definition id of 00000000-0000-0001-0000-000000000001 are the culprit. Assuming these are created when org.killbill.invoice.enabled=false is set. Updating https://github.com/killbill/killbill/blob/master/util/src/main/java/org/killbill/billing/util/tag/api/DefaultTagUserApi.java#L78 to set includeSystemTags to true in getTagDefinitions call corrects the issue in our environment... But this will result in the __PARK__ tags being inserted into the analytics_account_tags table. Is this the correct approach? If so, I can open a pull request in the killbill project. Let me know! 😀

from killbill-analytics-plugin.

@beccagaspard Yes, i think changing the includeSystemTags flag from false to true would solve the analytics problem. However i am not sure we always want to return the PARK_TAG_DEFINITION_ID, so maybe we need to enhance our TagUserApi to decide on the behavior?

@pierre Any thoughts?

from killbill-analytics-plugin.

I'm curious why we don't return system tags today... To make this even more confusing, DefaultTagInternalApi does return them (unused API though).

I would be inclined to return them.

from killbill-analytics-plugin.

Is this approach ok? Just overloaded getTagDefinitions to optionally accept includeSystemTags as a parameter.

killbill/killbill#787
killbill/killbill-api#32
#72

from killbill-analytics-plugin.