kikisito / nfcnotes Goto Github PK

NFCNotes is a Spigot 1.21+ plugin that allows you to withdraw money using notes. Those notes can also be used to redeem money.

License: GNU General Public License v3.0

Java 100.00%

nfcnotes's People

Contributors

Stargazers

Watchers

Forkers

tominous llopeando

nfcnotes's Issues

If using a placeable/usable item as note, it will be used/placed as you redeem it

Describe the bug
One example is if you use sunflower item as note (because it looks like a coin), you will place the sunflower while you redeem it. The sunflower will not drop itself as a note if you break it, luckily.

To Reproduce
Set material to sunflower, withdraw some money, place on ground.

Expected behavior
I would expect to not be able to place it, since it's money.

CustomModelData

int getCustomModelData()
Gets the custom model data that is set.
CustomModelData is an integer that may be associated client side with a custom item model.

Plugins should check that hasCustomModelData() returns true before calling this method.

Returns:
the localized name that is set

org.bukkit.inventory.meta

let me know if you have implant that feature
then the "banknotes" could have their own model

Make notes glow.

Hello! I was wondering if NFCNotes have the option to make a note glow. It's just a suggestion, I don't know if you guys have it I'm just asking.

Plugin crashing with every command i use.

For reproduce install the latest version of the plugin and try any command

https://del.dog/yulaviheni.txt log

[Feature Request]: Redeem Sound

Is your feature request related to a problem? Please describe.
No, I just think it would be a neat feature.

Describe the solution you'd like
It would be cool to have an option in the configuration file where I can set a sound that plays when you redeem money.

I use sunflowers as my notes which represent coins really well with their texture. The sound "block.chain.break" really sounds like a coin being stored, so i would like it to play with all of my redeems.

CustomModelData feature

Is your feature request related to a problem? Please describe.
We are actually making custom textures to our server, but NFCNotes does not have any option to specify the CustomModelData of an item so it can show the custom texture.

Describe the solution you'd like
An option in the config to be able to specify the CustomModelData of an item (for example; "custommodeldata_id: 2"), so you can take out NFCNotes with custom textures.

Describe alternatives you've considered
None.

Placeholders support

Hey, again. I just wanna ask if placeholders are supported for this plugin and, I was planning to add like the placeholder for the money. Or.. you could add it yourself?

Example:

Before: $1000
After: $1k

The placeholder is called:
%nf_###E0X_{placeholder}%

Now, I probably don't remember if your plugin already supports this. But I'm just double checking lol. Correct me if i'm wrong.

Be able to create NFC Notes from the console

Looking to have Voting be able to create NFC Notes. However, getting Only players can execute this command. Looking for a way to be able to create a NFC note from the console.

TradeShop Plugin Compatibility Issues

Describe the bug
I can't use notes with the TradeShop plugin.

To Reproduce
Steps to reproduce the behavior. Notes don't work with the tradeshop plugin: https://www.spigotmc.org/resources/tradeshop.32762/

Expected behavior
I expected to be able to use the notes as the cost or product. Tradeshop is typically pretty good at handling custom items.

Additional context
This might be on their end. I'm reporting it to them as well.

Withdrawing notes when inventory is full will delete your money

Describe the bug
If your inventory is full when you withdraw money, it will get deleted.

To Reproduce
Check your balance. Fill your inventory. Withdraw some money. Check your balance again. Your balance went down, but you do not have the notes you withdrew, effectively erasing the money.

Expected behavior
I would expect that either the notes should drop as items at the players feet, or the withdraw should be denied and the player is told in chat their inventory is full.

[Feature Request]: Option to make players withdraw notes only in multiples of a specific value

Describe the solution you'd like
When using this option, the withdraw command would only allow you to specify how much money to withdraw, and plugin automatically decides what amount of notes based on how much each note will be worth (which you can set with another option). This will allow, for example, forcing players to deal with ONLY $10 bills. Or instead maybe only $1 coins.

Error in the Console + does not work Paper1.19.4

Describe the bug
I upgraded my server today from Paper 1.19.3 to Paper 1.19.4, and noticed that NFC Notes no longer work.
When I want to redeem Notes, an error is also spammed into the Console.
->

[16:18:28 ERROR]: Could not pass event PlayerInteractEvent to NFCNotes v2.3.0
java.lang.IllegalStateException: zip file closed
        at java.util.zip.ZipFile.ensureOpen(ZipFile.java:831) ~[?:?]
        at java.util.zip.ZipFile.getEntry(ZipFile.java:330) ~[?:?]
        at java.util.jar.JarFile.getEntry(JarFile.java:518) ~[?:?]
        at java.util.jar.JarFile.getJarEntry(JarFile.java:473) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:195) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:588) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:155) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:150) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:521) ~[?:?]
        at me.hsgamer.bettereconomy.hook.vault.VaultEconomyHook.depositPlayer(VaultEconomyHook.java:76) ~[BetterEconomy-2.12.jar:?]
        at es.kikisito.nfcnotes.utils.Utils.depositSuccessful(Utils.java:38) ~[NFCNotes-2.3.0.jar:?]
        at es.kikisito.nfcnotes.listeners.InteractListener.redeem(InteractListener.java:111) ~[NFCNotes-2.3.0.jar:?]
        at com.destroystokyo.paper.event.executor.MethodHandleEventExecutor.execute(MethodHandleEventExecutor.java:40) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:git-Paper-510]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.19.4.jar:git-Paper-510]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:562) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:519) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:514) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:509) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:505) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItem(ServerGamePacketListenerImpl.java:2016) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundUseItemPacket.handle(ServerboundUseItemPacket.java:32) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundUseItemPacket.a(ServerboundUseItemPacket.java:8) ~[?:?]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:51) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1342) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:197) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1319) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1312) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1290) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1178) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) ~[paper-1.19.4.jar:git-Paper-510]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

To Reproduce
Upgrade Server to 1.19.4

Expected behavior
I have assumed that it works normally as in versions before.

Screenshots

Error Stacktrace

[16:18:27 ERROR]: Could not pass event PlayerInteractEvent to NFCNotes v2.3.0
java.lang.IllegalStateException: zip file closed
        at java.util.zip.ZipFile.ensureOpen(ZipFile.java:831) ~[?:?]
        at java.util.zip.ZipFile.getEntry(ZipFile.java:330) ~[?:?]
        at java.util.jar.JarFile.getEntry(JarFile.java:518) ~[?:?]
        at java.util.jar.JarFile.getJarEntry(JarFile.java:473) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:195) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:588) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:155) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:150) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:521) ~[?:?]
        at me.hsgamer.bettereconomy.hook.vault.VaultEconomyHook.depositPlayer(VaultEconomyHook.java:76) ~[BetterEconomy-2.12.jar:?]
        at es.kikisito.nfcnotes.utils.Utils.depositSuccessful(Utils.java:38) ~[NFCNotes-2.3.0.jar:?]
        at es.kikisito.nfcnotes.listeners.InteractListener.redeem(InteractListener.java:111) ~[NFCNotes-2.3.0.jar:?]
        at com.destroystokyo.paper.event.executor.MethodHandleEventExecutor.execute(MethodHandleEventExecutor.java:40) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:81) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:git-Paper-510]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.19.4.jar:git-Paper-510]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615) ~[paper-api-1.19.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:562) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:519) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:514) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:509) ~[paper-1.19.4.jar:git-Paper-510]
        at org.bukkit.craftbukkit.v1_19_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:505) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItem(ServerGamePacketListenerImpl.java:2016) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundUseItemPacket.handle(ServerboundUseItemPacket.java:32) ~[?:?]
        at net.minecraft.network.protocol.game.ServerboundUseItemPacket.a(ServerboundUseItemPacket.java:8) ~[?:?]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:51) ~[?:?]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1342) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:197) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1319) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1312) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:114) ~[?:?]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1428) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1174) ~[paper-1.19.4.jar:git-Paper-510]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320) ~[paper-1.19.4.jar:git-Paper-510]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Additional context
Add any other context about the problem here.

Commands dont work

I uploaded the mod jar file to my paper minecraft 1.16.5 server and it doesnt work, any help please?

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.