Comments (4)
Hi Fredrik, thanks for reaching out! ๐
Perhaps it would help you if I put in a configuration option that allows you to opt-out of single request mode?
from react-advertising.
That would work
from react-advertising.
Forked the project and tried removing enableSingleRequest
, which made the "This will impact impression counts." part of the error from Google console go away, but now we some times do not render every ad on the page.
So I guess this change is not needed after all, for our case it would probably need a bigger change, I assume we would need to define and display the ads in the activate
call or something. I'll see if I get the time to test it out at some point.
And just for clarification, we are using this with intersection observers, and we call activate
when the component is in the viewport. We track our ads by listening to GPT events, and everything is good with our own tracking, so everything seems to work as it should. The only problem here is that Google's own reporting (in DFP/Ad Manager) seems to report different numbers than our own, while we see (from GPT events) inscreen numbers around 90%, DFP/Ad Manager reports are saying 25-50%
from react-advertising.
OK, so nothing to do from my side at this point. I'll be happy to review your pull request, if you want to create one. If you do, please make sure your code changes are covered by unit tests.
from react-advertising.
Related Issues (20)
- Update readme to clearly link to the NPM package
- Recent releases are on NPM but not on the Github releases page
- chore: use testing-library instead of Enzyme
- chore: Upgrade to webpack 5
- No DFP request in the second page (or refresh) of a gatsby site HOT 1
- docs: Update documentation to include new features from version 4 HOT 1
- fix: โWindow is not definedโ error when rendering on the server
- feat: Configuration option to disable Prebid
- test: Set up E2E tests
- test: E2E test for lazy loading
- docs: Add a wiki page for contributors
- fix: this.queue.push is not a function HOT 2
- docs: Version 4 IE11 compatibility HOT 1
- feat: Provide TypeScript type definition file HOT 4
- Lazy loading does not work properly on Safari
- Error messages are suppressed in the console
- Add publish registry to package.json
- react-advertising with react native
- singleRequest doesn't work in any versions after 3.0.2 HOT 1
- Size Mapping not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-advertising.