Possibility of not calling enableSingleRequest() in setupGpt about react-advertising HOT 4 CLOSED

Hi Fredrik, thanks for reaching out! 😀

Perhaps it would help you if I put in a configuration option that allows you to opt-out of single request mode?

from react-advertising.

That would work

from react-advertising.

Forked the project and tried removing enableSingleRequest, which made the "This will impact impression counts." part of the error from Google console go away, but now we some times do not render every ad on the page.

So I guess this change is not needed after all, for our case it would probably need a bigger change, I assume we would need to define and display the ads in the activate call or something. I'll see if I get the time to test it out at some point.

And just for clarification, we are using this with intersection observers, and we call activate when the component is in the viewport. We track our ads by listening to GPT events, and everything is good with our own tracking, so everything seems to work as it should. The only problem here is that Google's own reporting (in DFP/Ad Manager) seems to report different numbers than our own, while we see (from GPT events) inscreen numbers around 90%, DFP/Ad Manager reports are saying 25-50%

from react-advertising.

OK, so nothing to do from my side at this point. I'll be happy to review your pull request, if you want to create one. If you do, please make sure your code changes are covered by unit tests.

from react-advertising.