Comments (2)
@pahund I was going through the code and I spotted that the
queue
is being set to an object instead of an array in the unmount function of lifecycle.
I can open a PR to fix that, though I'm not sure how to replicate it consistently.
That's a great catch, please do open a PR!
Do you have an alternative way to test?
Not yet. We could set up a Storybook story where we set up and tear down at the click of a button, then write a Cypress test. But for now, it will suffice if you change these blatantly wrong curly braces into square brackets.
from react-advertising.
@pahund I was going through the code and I spotted that the queue
is being set to an object instead of an array in the unmount function of lifecycle. It could explain that during the unmount we still have some calls to activate and as the queue is now an object, we don't have the push function
.
I can open a PR to fix that, though I'm not sure how to replicate it consistently.
Do you have an alternative way to test?
from react-advertising.
Related Issues (20)
- Update readme to clearly link to the NPM package
- Recent releases are on NPM but not on the Github releases page
- chore: use testing-library instead of Enzyme
- chore: Upgrade to webpack 5
- No DFP request in the second page (or refresh) of a gatsby site HOT 1
- docs: Update documentation to include new features from version 4 HOT 1
- fix: “Window is not defined” error when rendering on the server
- feat: Configuration option to disable Prebid
- test: Set up E2E tests
- test: E2E test for lazy loading
- docs: Add a wiki page for contributors
- docs: Version 4 IE11 compatibility HOT 1
- feat: Provide TypeScript type definition file HOT 4
- Lazy loading does not work properly on Safari
- Error messages are suppressed in the console
- Add publish registry to package.json
- react-advertising with react native
- singleRequest doesn't work in any versions after 3.0.2 HOT 1
- Size Mapping not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-advertising.