Comments (6)
I'm not sure if I quite understand what you want to do.
React Prebid provides a packaged version that has been run through babel (index.js) as well as a non-packaged ES6 version (index-esnext.js) which you can use if you prefer to transpile the code through your own Babel/webpack setup.
Are you proposing to add another bundle that has not been minified?
from react-advertising.
our webpack config is not set up to handle index-esnext.js. We don't want to transpile any third party node modules. So instead we use your index.js, however because it's minified it makes it hard to debug the code. For example using react dev tools I don't see the component names and can't set any breakpoints.
from react-advertising.
What's your intended use for index.js? Is this for installation via a script tag? If it's meant for npm installation then I think unminified code is always preferable?
from react-advertising.
Hi Matt,
your feature request is valid, I've done some research and looked at how other projects are doing this. I've created a separate issue that outlines how I think this should be solved, feel free to provide feedback:
- #20 – Improve Code Packaging and Delivery
We will have to do a major release for this, as people may rely on the default JS bundle to be minified. I cannot promise any delivery date.
If you want to take care of this in a pull request, I would be very grateful! 😀
from react-advertising.
@mattcolman
I've published a beta release with your changes: 3.0.0-beta.0
Can you please check if this fixes your issue and confirm? Then I'll release a final version after some more testing on my end.
from react-advertising.
yep works for me! Thanks!
from react-advertising.
Related Issues (20)
- Update readme to clearly link to the NPM package
- Recent releases are on NPM but not on the Github releases page
- chore: use testing-library instead of Enzyme
- chore: Upgrade to webpack 5
- No DFP request in the second page (or refresh) of a gatsby site HOT 1
- docs: Update documentation to include new features from version 4 HOT 1
- fix: “Window is not defined” error when rendering on the server
- feat: Configuration option to disable Prebid
- test: Set up E2E tests
- test: E2E test for lazy loading
- docs: Add a wiki page for contributors
- fix: this.queue.push is not a function HOT 2
- docs: Version 4 IE11 compatibility HOT 1
- feat: Provide TypeScript type definition file HOT 4
- Lazy loading does not work properly on Safari
- Error messages are suppressed in the console
- Add publish registry to package.json
- react-advertising with react native
- singleRequest doesn't work in any versions after 3.0.2 HOT 1
- Size Mapping not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-advertising.