Giter Club home page Giter Club logo

Comments (11)

EeliK avatar EeliK commented on July 28, 2024

The whole model is wrong, it's mirrored. See https://www.tme.eu/Document/4ddeead22020b5eb532ee6fb8f44e788/IRM-03-spec.pdf

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

corrected footprint submitted here:

KiCad/kicad-footprints@4a7a688

Sorry for the the mess but this whole github + git is pile a crap. I wanted 'one or two patches' per branches one branch one PR.

from kicad-packages3d.

evanshultz avatar evanshultz commented on July 28, 2024

@Franck78
It looks like the footprint is fine to me. The origin and rotation are correct for a THT footprint. It's the 3D model that needs to be fixed.

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

euh no ! You have the pdf. for comparison.

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

eu yes ! bottom view says the datasheet.
So just make the orientation same as other IRM THT is ok.

And redraw the the 3d

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

eu yes ! bottom view says the datasheet.
So just make the orientation same as other IRM THT is ok.

And redraw the the 3d

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

@evanshultz ,
regenerated wrl for this thing is here:
Just from the script

https://github.com/KiCad/kicad-packages3D/compare/master...Franck78:pwled?expand=1

from kicad-packages3d.

evanshultz avatar evanshultz commented on July 28, 2024

@Franck78
Thanks for looking at this. If you've fixed it, please submit the STEP and WRL files as a PR to the repo so it can be reviewed and merged. And if you corrected a script, please submit a PR for that as well. Again, I'm not too familiar with the 3D model part of the library.

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024
  • the existing .step is OK. No need to change
  • the script is not modified
  • the PR done 'pwled', updated with photos

acdc-back

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

while working with the sourcefiles for building this image, I also noticed missing or wrong 3dmodels for

  • hilink_hlk
  • IRM-05
  • IRM-10
  • IRM-60
  • RAC-05
  • TMG-15
  • Syntec
  • CRE1
  • MGJ2D
  • MGJ3
  • NCS1S
  • TDN-05
  • THD-15
  • TMR 1SM
  • TMR-2
  • XPPOWER

Probably a lot of them doable with the script, meaning doing the job of updating the 3drepo only 'once'.

Don't merge to soon, but not in ten years ;)

from kicad-packages3d.

Franck78 avatar Franck78 commented on July 28, 2024

~140 3dmodels ready (scripted).

what next Librarians ?

from kicad-packages3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.