khinkhinn / ped Goto Github PK

The error message for the add command displays a wrong example of the command usage.
"Example: add q/John Doe a/311, Clementi Ave 2, #2-25 t/friends t/owesMoney" seems to be for AB3 instead of Medmoriser.

input:

output:

Sorry for nitpicking but is this supposed to be a fullstop?

Screenshot 2020-10-30 at 4.30.27 PM.png

Similar to the add command feature, the example for the find feature might also have to be updated to a medical question and answer instead of an AB3 related search term.

Perhaps an example of the answer command could be included? Maybe with reference to the quiz command example, and the example could also include the expected result for an incorrect and correct answer.

Screenshot 2020-10-30 at 4.51.41 PM.png

Overall comments:
hello i didnt want to start a new issue to talk about my overall comments bcus i wasnt sure if it would affect the total score of this pe so i hope you dont mind that im writing it here. i think i would like to start off by saying that overall the app is good, and the messages displayed (such as error and success messages) are quite good and friendly! the new gui implemented for the quiz feature is also good (i think its rather clean), and ive added my suggestions for the quiz feature in a seperate issue. most of the errors i caught are relatively small documentation/example features which i think can be cleaned up quickly! overall good job and i hope that none of my comments upset you too much!! jiayous :)

Format and example seems to be missing that the tag function can be included when entering the input, unless the tag feature is not supposed to be used when adding?

However command format in Medmoriser itself states that tag can be included.
Screenshot 2020-10-30 at 4.28.51 PM.png

Just a suggestion, would it be better for integers <= 0 to display the same error message as integers that are more than the total number of QAndAs in the database?

Would it be possible for the user to have more (or unlimited) attempts to answer the quiz question before having the answer displayed?

Perhaps if there is sufficient time, and if it doesn't require too much work, perhaps an addtional command to display the answer could be added. For example, the user might try to answer the question a few times using the "answer" command, before giving up and asking Medmoriser to display the answer with maybe a "display" command.

I thought this might be worth considering as personally I would want a few attempts to try and answer the question before giving up.