conf_robber's People
conf_robber's Issues
Зачем так сложно?
fn find_by_regex(text: &String, expression: RegexTypes) -> regex::FindCaptures {
match expression {
RegexTypes::All => RE_ALL_IDS.captures_iter(&*text),
RegexTypes::ElementsOfType => RE_ELEMENTS_OF_TYPE.captures_iter(&*text),
RegexTypes::IdAndName => RE_ID_AND_NAME.captures_iter(&*text),
}
}
Зачем передавать в функцию ссылку на строку &String
, а потом разыменовывать и снова брать ссылку на строку &*text
?
Передали как &str
и все прекрасно.
panic! на каждую проблему?
error!("Failed finding id of configuration.");
panic!("Failed finding id of configuration.");
В библиотеках использовать panic!
?
Для работы с ошибками есть Result<T, E>
.
Передал пользователю библиотеки Result и пусть он решает, что с этим делать, не?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.