khalidmesbah / image-processing-api Goto Github PK

Providing endpoint not only helps me as a reviewer to check the application but also any other developer working on the application to run the application easily.
Refer the screenshot.

Since I could not review image processing, I could not tell if you have provided error messages.
Although, as tip, I would provide you common error messages scenarios.
Missing filename, height or width.
Invalid input for filename e.g. fjord123.
Invalid input for height or width e.g. height=a, height=0 or height=-1.

format the code in readme.md file

It is very important to keep dependencies separate from devDependencies.
DevDependencies are used when you only need the packages for development.
They are not used in testing like jasmine, supertest etc.
In fact, you would not even need type definition support for any package since the production code would be build code that is written in javascript.

Prettier and Lint should be configured to run only on TS files before they build to JS.
You need not run it on JS or JSON files but it should run on all TS files.
Also, you can define your own configuration and rules for these formatters.
Use src/**/.ts instead of ./src/.ts in scripts.

Make the test pass

https://github.com/khalidMesbah/Image-Processing-API/blob/570c328909e67cc012f81d865027ac468d02cb7b/views/index.ejs#L8

Image resizing does not work.
This maybe due to the way you have provided path to images.
It may work perfectly in your system but it would fail at other places.
Use __dirname to define absolute path,

The folder in which you are looking for resized images does not exist.