khady / ocaml-argon2 Goto Github PK

This library doesn't work on macOS 10.14.6 . argon2 is installed via homebrew.

✗ ls /usr/local/lib/ | grep argon2
libargon2.1.dylib
libargon2.a
libargon2.dylib

Changing the Dl.open call here https://github.com/Khady/ocaml-argon2/blob/master/src/argon2.ml#L5
from libargon2.1.so to libargon2.1.dylib fixes the issue.

I'm willing to send a PR to fix this but I'm not sure how to do this. Please advice on the proper fix that works cross-platform

I have some questions regarding the API:

• The API exposes modules D, I, and ID with generic functions. It seems redundant. Why not just have generic functions?
• Considering the lack of conversion functions from string to encoded or hash, it seems that modules D, I or ID seems not usable in practice.
• For the generic functions, Why does the hash function return both a hash and an encoded datatype? It seems only the second one can be used with verify.
• More generally, what are the differences between a hash and encoded? Why not just use one datatype?
• I am wondering why the hash function takes an encoded_len argument. It seems that this value comes from the function encoded_len. Wouldn't be simpler to not expose encoded_len and let the function hash compute this length by itself?

I was having trouble with static linking of this library, due to the symbols not being found at runtime, so I tried switching it over to use stub generation master...joprice:stubs. This got it to work, but while doing so, I noticed that argon2id_verify calls argon2d_verify https://github.com/Khady/ocaml-argon2/blob/master/src/argon2.ml#L227.

let argon2id_verify = verify "argon2d_verify"

The current version of this package in OPAM is 0.2, which requires OCaml < "4.06.0".

It seems the current version here on github is not pushed to OPAM.