Giter Club home page Giter Club logo

Comments (7)

kgar avatar kgar commented on June 20, 2024 1

Thank you. Beta is coming soon, and I'll be putting all my energy into this problem.

I am hoping I can get in touch with some of the module devs to collaborate on how the API should look and feel. I will be reading through those modules to see how they're currently being done and maybe even submit my own PRs after I have API coverage available for the kinds of functionality they are providing.

When compatibility is restored, their tabs should appear in places like Initial Sheet Tab, Default Tab Selection, and Actor Tab Selection, like first class citizens 🤞

from foundry-vtt-tidy-5e-sheets.

kgar avatar kgar commented on June 20, 2024

Hello, thank you for checking out the rewritten sheets!

With the rewrite, a lot of things are very different under the hood from regular Foundry sheets. This will have broken compatibility with numerous sheet-augmenting modules. When these sheets leave alpha testing and move on to beta, module compatibility changes will begin in earnest.

I will refer back to this issue to see what can be done.

from foundry-vtt-tidy-5e-sheets.

Ikabodo avatar Ikabodo commented on June 20, 2024

I think this change you are doing is really good for this.

One problem with the above modules is that they add tabs on sheet update hooks. That can be very performance heavy. With your solution tabs can be added at the core (at least that is what I think it looks like).

Nice work!

from foundry-vtt-tidy-5e-sheets.

kgar avatar kgar commented on June 20, 2024

I have started some github discussions on how to provide module compatibility for new tabs.
I will be awaiting and participating in any discussion on the topic for another couple of weeks.
#93

When I reach the end of that period, I'll begin work on the API and will target one module at a time until the overwhelming majority of use cases are covered.

from foundry-vtt-tidy-5e-sheets.

kgar avatar kgar commented on June 20, 2024

Let's go... Downtime Dnd5e is now compatible!
Crash's module may not be feasible, since Downtime Dnd5e is the spiritual successor, but I will discuss it with Crash.
I've submitted an issue to Ethck's Downtime Tracking to get the conversation started.
I'll be getting the conversation started with Beaver's Crafting soon.

from foundry-vtt-tidy-5e-sheets.

kgar avatar kgar commented on June 20, 2024

Beaver's Crafting is in!
Hoping to hear from Ethck sometime soon.

from foundry-vtt-tidy-5e-sheets.

kgar avatar kgar commented on June 20, 2024

Ethck has begun the work to add compatibility 🎉
I helped with testing, and I provided some feedback. It is now Ethck's move.

from foundry-vtt-tidy-5e-sheets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.