keybase / stellarnet Goto Github PK

I'm trying to sign a transaction with KeyBase client SEP-7 handler, and I get request parameter "xdr" is invalid, but Stellar laboratory decodes this transaction successfully:

AAAAAgAAAACfPd+FSFlAx6BAfyJSF/nTy99q5NqNJ/ZB2HYUw2RilAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAEkxvZ2dpbmcgaW50byBWZWNoZQAAAAAAAQAAAAAAAAAKAAAABW5vbmNlAAAAAAAAAQAAABhvV3ZzemtVUVJZZmNnbVg4WFRRMXJLeDUAAAAAAAAAAA==

What's wrong? Is your vendored XDR library up-to-date?

Currently when using replacements in SEP7 Stellar URIs, it appears that Keybase has the ability to replace source accounts in transactions. However, that is not very useful if it does not also replace the sequence number. Unfortunately adding the "seqNum" replace param results in a "Sorry you cannot use this replace param" error.

Here is how I tested this:

1. Created a Stellar URI sending 0.01 XLM to my own account, with a different source account, and the sequence number of that source account. This Stellar URI specifies that sourceAccount should be replaced.

web+stellar:tx?xdr=AAAAAO6JQTfmXnAUTbjZ%2FQ6kMiwYQK96tab9CrOkRDhgleCvAAAAZAEpCUIAAAAEAAAAAAAAAAAAAAABAAAAAAAAAAEAAAAARQ8lgldVTeCUV%2BoysRUOl0J13Iuxv%2Fa1l%2FDuWahtdwwAAAAAAAAAAAABhqAAAAAAAAAAAA%3D%3D&origin_domain=test.stellarguard.me&replace=sourceAccount%3ASRC%3BSRC%3Athe+source+account&signature=hYKXcxDPESUHdbJP9aCWMTnYNP0MUJsRnddWRQ1H15r8%2BUS86V5LRQo3yi4Ft771ClRphv8Q%2BbiA8sZ1xyVkCQ%3D%3D

2. When trying to submit this, I get a "Stellar network error" message.

3. Created a Stellar URI that was the same as before, but used the correct sequence number for my own account (still used the other account's source account).

web+stellar:tx?xdr=AAAAAO6JQTfmXnAUTbjZ%2FQ6kMiwYQK96tab9CrOkRDhgleCvAAAAZAFAdlYAAAAcAAAAAAAAAAAAAAABAAAAAAAAAAEAAAAARQ8lgldVTeCUV%2BoysRUOl0J13Iuxv%2Fa1l%2FDuWahtdwwAAAAAAAAAAAABhqAAAAAAAAAAAA%3D%3D&origin_domain=test.stellarguard.me&replace=sourceAccount%3ASRC%3BSRC%3Athe+source+account&signature=gbcazRsdRuJi2A085kkK8R%2F66LPaV%2B%2FTaFpaiG%2F%2FdfDPtFTJxn2Nd2xO6Ssxjpy3esOr3lr3eUe5tCWOQ%2FkNDA%3D%3D

4. Clicking this succeeded, indicating that it replaced the source account, but left the sequence number.

Presently, it appears that source account replacements are kind of worthless since you have to have set the correct sequence number ahead of time. Supporting the seqNum replacement param would alleviate this and make this so much more useful.

Note: I have a playground for Stellar URIs that you can try here (to make the link clickable at least): https://stellarguard.github.io/stellar-uri/demo

Uri: web+stellar:tx?xdr=AAAAAJ8934VIWUDHoEB%2FIlIX%2BdPL32rk2o0n9kHYdhTDZGKUAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAASTG9nZ2luZyBpbnRvIFZlY2hlAAAAAAABAAAAAAAAAAoAAAAFbm9uY2UAAAAAAAABAAAAGHpRTzM1bHhheFhXbkJNSWRYOHNsQm51YwAAAAAAAAAA&callback=http%3A%2F%2Flocalhost%3A3000%2Fauth%2Fpage%2Fstellar

Result:
stellar network error