You do realize that if you execute cleanup.sh all images and containers will be removed, not only those specific to this project?

Just kidding, I saw it in the readme, however : this seems like a very dangerous thing to put in a shell script.

My advice would be to leave image / container maintenance to the user and to not try to offer 'management services' to your users.

In essence, you should always see your Docker containers as ephemeral : meaning they only last a short time.

This means that, once a container served it's purpose, it should be removed from the system, unlike a VM, which can be re-used for other projects. Never forget : containers are like extended classes from your base images, and they can be moulded for whatever purpose you need them to perform. If you need another extended class you do not 'empty' the existing class and reuses it, you make a new class extended from the parent class (in this case the image).

A simple example : in webdev land you often need to load in a project in order to debug it. Why would you ever want to 'clear' an existing container in order to fill it with the new project to debug, when you can simply use the existing image and create a new container for that purpose?

In that regard, the cleanup.sh script of the docker drupal container seems pointless : is there ever going to be a reason you want an existing container (drupal container that is) emptied of it's civi / drupal installation?

If you need a new container for another project you simply change the docker-compose.yml file to suit your needs and create another, ready to use in another project. That is the real strength of Docker, the speed in which something like this can be achieved.

This is only my two cents on the subject, but it might be worth taking a deep look as to why the cleanup.sh would ever be necessary :)

I do not understand quite clearly what the purpose of this shell script would be?

For instance :

1. Checking versions is fine, but you should first check if the programs are installed (for instance, docker machine is quite unnecessary on Linux machines :) )

2. Doing a "docker images" and a "docker ps -a" does not prove a thing : the amount of images / containers is irrelevant to the functioning of Docker (and might confuse users of this Docker instance, they will see their own images / containers)

I'm guessing this is just a helper script, but I would either mention this or completely remove it from the repo.

Is there any specific reason why the images need to be built locally instead of downloaded from a online repo, like Docker Hub?

I'm only mentioning it because there doesn't seem to be a security risk involved, or project specific configuration 'embedded' into the image(s).

That way you can directly use docker-compose to build the images (if needed), instead of introducing a manual step.